chore: fix some style problems.

apache · May 9, 2023 · f80557c · f80557c
1 parent b056310
commit f80557c
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/analytic_engine/src/instance/open.rs b/analytic_engine/src/instance/open.rs
@@ -65,7 +65,7 @@ impl Instance {
             store_picker.default_store().clone(),
         ));
 
-        let table_snapshot_provider = Arc::new(TableMetaSetImpl {
+        let table_meta_set_impl = Arc::new(TableMetaSetImpl {
             spaces: spaces.clone(),
             file_purger: file_purger.clone(),
             preflush_write_buffer_size_ratio: ctx.config.preflush_write_buffer_size_ratio,
@@ -74,7 +74,7 @@ impl Instance {
             ctx.config.manifest.clone(),
             manifest_storages.wal_manager,
             manifest_storages.oss_storage,
-            table_snapshot_provider,
+            table_meta_set_impl,
         )
         .await
         .context(OpenManifest)?;

diff --git a/analytic_engine/src/manifest/details.rs b/analytic_engine/src/manifest/details.rs
@@ -35,10 +35,11 @@ use wal::{
     },
 };
 
-use super::meta_edit::{MetaEdit, Snapshot};
 use crate::{
     manifest::{
-        meta_edit::{MetaEditRequest, MetaUpdate, MetaUpdateDecoder, MetaUpdatePayload},
+        meta_edit::{
+            MetaEdit, MetaEditRequest, MetaUpdate, MetaUpdateDecoder, MetaUpdatePayload, Snapshot,
+        },
         meta_snapshot::{MetaSnapshot, MetaSnapshotBuilder},
         LoadRequest, Manifest, SnapshotRequest,
     },
@@ -178,9 +179,9 @@ impl MetaUpdateLogEntryIterator for MetaUpdateReaderImpl {
     }
 }
 
-/// Table snapshot provider
+/// Table meta set
 ///
-/// Mainly for getting the [TableManifestData] from memory.
+/// Get snapshot of or modify table's metadata through it.
 pub(crate) trait TableMetaSet: fmt::Debug + Send + Sync {
     fn get_table_snapshot(
         &self,
@@ -462,7 +463,6 @@ impl Manifest for ManifestImpl {
         let shard_id = shard_info.shard_id;
         let location = WalLocation::new(shard_id as u64, table_id.as_u64());
         let space_id = meta_update.space_id();
-        let table_id = meta_update.table_id();
 
         self.maybe_do_snapshot(space_id, table_id, location, false)
             .await?;

diff --git a/analytic_engine/src/manifest/meta_edit.rs b/analytic_engine/src/manifest/meta_edit.rs
@@ -16,8 +16,8 @@ use snafu::{Backtrace, OptionExt, ResultExt, Snafu};
 use table_engine::table::TableId;
 use wal::log_batch::{Payload, PayloadDecoder};
 
-use super::meta_snapshot::MetaSnapshot;
 use crate::{
+    manifest::meta_snapshot::MetaSnapshot,
     space::SpaceId,
     table::{
         data::{MemTableId, TableShardInfo},