remove unnecessary clone, make fields in Shard private.

apache · Jul 11, 2023 · 78a7de8 · 78a7de8
1 parent 90a9886
commit 78a7de8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/cluster/src/shard_operator.rs b/cluster/src/shard_operator.rs
@@ -227,16 +227,14 @@ impl ShardOperator {
         }
 
         // Create the table by operator afterwards.
-        let catalog_name = ctx.catalog;
-
         let (table_engine, partition_info) = match table_info.partition_info.clone() {
             Some(v) => (ctx.partition_table_engine.clone(), Some(v)),
             None => (ctx.table_engine.clone(), None),
         };
 
         // Build create table request and options.
         let create_table_request = CreateTableRequest {
-            catalog_name: catalog_name.clone(),
+            catalog_name: ctx.catalog,
             schema_name: table_info.schema_name.clone(),
             table_name: table_info.name.clone(),
             table_id: Some(TableId::new(table_info.id)),

diff --git a/cluster/src/shard_set.rs b/cluster/src/shard_set.rs
@@ -51,8 +51,8 @@ impl ShardSet {
 ///
 /// NOTICE: all write operations on a shard will be performed sequentially.
 pub struct Shard {
-    pub data: ShardDataRef,
-    pub operator: tokio::sync::Mutex<ShardOperator>,
+    data: ShardDataRef,
+    operator: tokio::sync::Mutex<ShardOperator>,
 }
 
 impl std::fmt::Debug for Shard {