fix #4818#4823
Merged
Merged
Conversation
hansva
requested changes
Jan 26, 2025
Comment on lines
+180
to
+195
| if (trimType != null) { | ||
| switch (trimType) { | ||
| case ConcatFieldsMeta.TRIM_TYPE_LEFT: | ||
| targetField.append(valueMeta.getString(valueData).replaceAll("^\\s+", "")); | ||
| break; | ||
| case ConcatFieldsMeta.TRIM_TYPE_RIGHT: | ||
| targetField.append(valueMeta.getString(valueData).replaceAll("\\s+$", "")); | ||
| break; | ||
| case ConcatFieldsMeta.TRIM_TYPE_BOTH: | ||
| targetField.append(valueMeta.getString(valueData).trim()); | ||
| break; | ||
| default: | ||
| targetField.append(valueMeta.getString(valueData)); | ||
| break; | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
We have a function in Const -> org.apache.hop.core.Const#trimToType
Contributor
Author
There was a problem hiding this comment.
Good to know let me use it and fix the code
Contributor
Author
|
@hansva I applied the change you suggested |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #4818 Concat transform does not trim fields
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean install apache-rat:checkto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.git rebase -i.addresses #123), if applicable.To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.