HIVE-29300: Wrong estimation for num rows in EXPLAIN with histogram statistics #6189
+258
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deniskuzZ
reviewed
Nov 17, 2025
ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Nov 17, 2025
ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java
Show resolved
Hide resolved
thomasrebele
force-pushed
the
tr/HIVE-29300
branch
from
ce9dbbf to
8aa0d4f
Compare
Contributor
Author
|
Thank you for the review, @deniskuzZ! I've addressed your comments. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix the statistics calculation in
org.apache.hadoop.hive.ql.optimizer.stats.annotation.StatsRulesProcFactory.FilterStatsRule#evaluateComparatorWithHistogram.Why are the changes needed?
See https://issues.apache.org/jira/browse/HIVE-29300.
Does this PR introduce any user-facing change?
Yes, it fixes the row count estimations when histogram statistics are available. This is necessary for AND predicates.
How was this patch tested?
qfile test