HIVE-29302: Wider Tez session open scope should be guarded to prevent local resource leaks #6161
+77
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abstractdog
force-pushed
the
HIVE-29302
branch
from
c2f235b to
1cd40f6
Compare
abstractdog
force-pushed
the
HIVE-29302
branch
from
1cd40f6 to
8e11ed8
Compare
asf-ci-hive
added
tests pending
tests passed
and removed
tests failed
tests pending
labels
… local resource leaks
abstractdog
force-pushed
the
HIVE-29302
branch
from
8e11ed8 to
5cac81e
Compare
|
Contributor
Author
not about to handle this: no more useful contextual information can be added here than "hey, I caught this exception, cleaned up, and now re-throwing the session open failure exception" |
Contributor
|
Changes makes sense to me, to cleanup scratch directory in case of exception before LGTM +1 (non-binding) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Encapsulate a wider code path in error-handling while opening a Tez session.
Why are the changes needed?
A scratch directory can leak if an exception is thrown after it’s created and resources have been placed into it.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Unit test added.