HIVE-29001: Remove duplicate mockito dependency in hive-common pom causing maven warnings #5857
Conversation
…using maven warnings
| @@ -254,12 +254,6 @@ | |||
| <artifactId>tempus-fugit</artifactId> | |||
| <scope>test</scope> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>org.mockito</groupId> | |||
| <artifactId>mockito-core</artifactId> | |||
There was a problem hiding this comment.
The same dependency is present at
Line 362 in 39c88d7
|
CC @ayushtkn. |
|
@ayushtkn, quick question unrelated to the PR. But in hive tarball which we ship, log4j properties is picked from common/src/main/resources/hive-log4j2.properties which doesn't contain the log4j cleanup changes. Should we address this? Reason why I am asking is, if i use default log4j properties present in tarball then on starting hive services i get the following warning:
|
|
There was a problem hiding this comment.
LGTM! Thanks for the PR @Aggarwal-Raghav. I will merge it if tests come back green!
I've noticed that scope definition for mockito-core is duplicated in almost all places where the dependency is declared but it is redundant since we are doing it in the dependency management section. I guess we could do some additional cleanup around this in a follow-up ticket. Moreover, it would be interesting to see if the dependency can be dropped from some of modules; not sure it is used everywhere where it is declared.
Regarding the comments around the LOG4J cleanup it would be more appropriate to discuss it under the respective JIRA ticket. If you believe there is an issue then it would be even better to log directly a new JIRA ticket and cc the appropriate people.
What changes were proposed in this pull request?
Check HIVE-29001, duplicate dependency of mockito throwing maven warning during build
Why are the changes needed?
To have a clean maven build output :-)
Does this PR introduce any user-facing change?
NO
How was this patch tested?
Will see CI output