HIVE-25616: Hive-24741 backport to 2.3 #2730
Conversation
nssalian
changed the title
| * all the partitions and hence we can attempt to use a directSQL equivalent API which | ||
| * is considerably faster. | ||
| * @param partVals The partitions values used to filter out the partitions. | ||
| * @return true if partVals is empty or if all the values in partVals is empty strings. |
There was a problem hiding this comment.
I know this is from the original patch but looks like this javadoc is incorrect. The method actually returns false if partVals is empty. I don't really remember now why that was the case. Perhaps you can look at this if you have some cycles? If not, please fix the java doc.
| @@ -2571,8 +2571,8 @@ private Collection getPartitionPsQueryResults(String dbName, String tableName, | |||
| * all the partitions and hence we can attempt to use a directSQL equivalent API which | |||
| * is considerably faster. | |||
| * @param partVals The partitions values used to filter out the partitions. | |||
| * @return true if partVals is empty or if all the values in partVals is empty strings. | |||
| * other wise false. If user or groups is valid then returns false since the directSQL | |||
| * @return false if partVals is empty, true if all the values in partVals are empty strings and | |||
There was a problem hiding this comment.
the comment should be "...and otherwise false for all the other cases" Or more simply, the method returns true only when partVals is non-empty and contains only empty strings, otherwise false.
kgyrtkirk
added
tests failed
tests pending
tests unstable
and removed
tests pending
tests failed
labels
|
Thanks for addressing the changes. I don't think the precommits are stable for Hive 2.x branch so I am willing to override testing results and do a force merge. |
|
Thanks @vihangk1 for the review. |
|
I am overriding the tests failed label in this case. Hive 2.x is a pretty old branch. We don't have a baseline of how stable are the tests on that branch in the first place. |
|
Thanks @nssalian for your contribution. |
…wed by Vihang Karajgaonkar) Closes (apache#2730)
…wed by Vihang Karajgaonkar) Closes (apache#2730)
…wed by Vihang Karajgaonkar) Closes (apache#2730)
…wed by Vihang Karajgaonkar) Closes (apache#2730)
What changes were proposed in this pull request?
This PR is a backport of #1948 wherein the the performance of get_partitions_ps_with_auth is improved into the Hive-2.3 branch.
Why are the changes needed?
Performance improvement for a HMS API on the Hive-2.3 branch since Spark continues to use Hive 2.3.x.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Same tests as original patch.