Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIVE-25242. Query performs extremely slow with vectorized.adaptor = chosen #2390

Merged
merged 2 commits into from
Jun 24, 2021

Conversation

zeroflag
Copy link
Contributor

If hive.vectorized.adaptor.usage.mode is set to chosen only certain UDFS are vectorized through the vectorized adaptor.

Queries like this one, performs very slowly because the concat is not chosen to be vectorized.

select count(*) from tbl where to_date(concat(year, '-', month, '-', day)) between to_date('2018-12-01') and to_date('2021-03-01');  

@zeroflag
Copy link
Contributor Author

retest this please

Copy link
Contributor

@pgaref pgaref left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @zeroflag ! Changes LGTM but this is essentially moving concat UDF to the CHOSEN list -- shall we explicitly mention this on the ticket?
Are we expecting any side effects from this?

@zeroflag
Copy link
Contributor Author

@pgaref yes, I added a note on the ticket about whitelisting the concat. The patch was tested by a customer and didn't report any side effects.

@abstractdog abstractdog merged commit 3fe1d58 into apache:master Jun 24, 2021
@abstractdog
Copy link
Contributor

merged, thanks @zeroflag for the patch and @pgaref for the review!

dengzhhu653 pushed a commit to dengzhhu653/hive that referenced this pull request Dec 15, 2022
…hosen (apache#2390) (Attila Magyar reviewed by Panagiotis Garefalakis)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants