-
Notifications
You must be signed in to change notification settings - Fork 4.8k
HIVE-24568: Fix guice compatibility issues #1812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks @wangyum ! I tried your PR and now seeing this failure on my local laptop:
|
avro-mapred depends on a different servlet version so maybe it is accidentally excluded. |
May be we need to upgrade jetty: https://issues.apache.org/jira/browse/HIVE-21961 |
This was referenced Dec 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr fix guice compatibility issues.
druid dependency guice 4.1.0:
hive/itests/qtest-druid/pom.xml
Line 46 in f7ec294
hadoop dependency guice 4.0.0:
https://github.com/apache/hadoop/blob/release-3.1.0-RC1/hadoop-project/pom.xml#L92
https://github.com/google/guice/blob/4.1/core/src/com/google/inject/util/Types.java#L110-L112
https://github.com/google/guice/blob/4.0/core/src/com/google/inject/util/Types.java
Why are the changes needed?
Fix compatibility issues.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
N/A.