-
Notifications
You must be signed in to change notification settings - Fork 4.8k
HIVE-23980: Shade Guava from hive-exec in Hive branch-2 #1397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cc @sunchao |
@viirya seems there is no new testing failing which is good. |
@sunchao But I saw some test failures?
What existing failing means? |
@viirya it probably means those tests were already failing previously. However I was not able to find a history for this. According to this comment, it seems many tests were failing after we enabled CI for branch-2. cc @belugabehr - wonder if you have any info on this. Thanks. |
Any idea about which tests I should take a look at? |
@viirya I see most of these test failures are related to Calcite so seems not related, and they were failing previously. Maybe we can trigger the tests again by force push. Also it'd be great if we can verify locally by selecting a few test before and after the PR. |
I tried to run failed tests locally.
But I cannot reproduce the test failure. |
@sunchao Can you reproduce the test failure locally? |
NO I took two failed tests and can't reproduce them locally, with and without your PR. |
Hm, it makes harder to debug... |
Yeah, however I think this PR is trivial enough and I don't see the tests are related. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…eviewed by Chao Sun) (#1397)
…g-Chi, reviewed by Chao Sun) (apache#1397)" This reverts commit 82b8bbf.
What changes were proposed in this pull request?
This PR proposes to shade Guava from hive-exec in Hive branch-2. This is basically for triggering test for #1356.
Why are the changes needed?
When trying to upgrade Guava in Spark, found the following error. A Guava method became package-private since Guava version 20. So there is incompatibility with Guava versions > 19.0.
This is a problem for downstream clients. Hive project noticed that problem too in HIVE-22126, however that only targets 4.0.0. It'd be nicer if we can also shade Guava from current Hive versions, e.g. Hive 2.3 line.
Does this PR introduce any user-facing change?
Yes. Guava will be shaded from hive-exec.
How was this patch tested?
Built Hive locally and checked jar content.