-
Notifications
You must be signed in to change notification settings - Fork 4.8k
HIVE-23998: Upgrade guava to 27 for Hive branch-2 #1395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cc @sunchao |
@sunchao Yeah, seems the tests was triggered. |
TestAccumuloCliDriver was running for 3 days - I stopped it...maybe this change also needs an accululo upgrade? |
@kgyrtkirk I see there is a timeout of 6 hours in Jenkinsfile, curious how the test can still run for so long. |
on branch-2 I don't see any timeout set...that's why it could run indefinetly |
Ah I see. @viirya do you see the Accumulo test failures related? |
Not check it yet, I will look at it later today. |
Hm, I don't see Accumulo test failure there http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-1395/1/tests. Tried to run I also ran it in current branch-2, but it's also stuck. Is this correct way to run this test?
|
@viirya I think just
is suffice. You also need to build the itests module first. For me, the test on branch-2 didn't stuck but failed with the following error:
So don't understand why it stuck for so long in the CI. |
@viirya Regardless of this, like you mentioned, the biggest blocker for this is Hadoop 2.7.2 which depends on a lower version of Guava, and I don't see a way to solve this other than upgrading the Hadoop version (Hadoop only start shading Guava from 3.0.0 I think). |
@sunchao Technically, if we shade Guava in Hive, we should be able to work with Hadoop 2.7.2 without conflict with its older Guava. |
I mean Hive. Not sure if it is totally correct or I may miss anything, but I think if we shade Guava in Hive, is Hadoop 2.7.2 which depends on older Guava still a problem here? By shading Guava in Hive, I think Hive can use newer Guava, and let Hadoop uses older Guava? |
You can try. I think the hive-exec JAR produced will have no issue working with older version of Hadoop/Guava, but I don't know others like unit tests work in this case. |
Hm, ok, let me try to shade Guava too in this PR, and see how it goes. |
9bddc80
to
2ccbd3c
Compare
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
What changes were proposed in this pull request?
This PR proposes to upgrade Guava to 27 in Hive branch-2. This is basically used to trigger test for #1394.
Why are the changes needed?
When trying to upgrade Guava in Spark, found the following error. A Guava method became package-private since Guava version 20. So there is incompatibility with Guava versions > 19.0.
Does this PR introduce any user-facing change?
Yes. This upgrades Guava to 27.
How was this patch tested?
Built Hive locally.