Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make the controller response be easy #2679

Merged
merged 5 commits into from
Sep 6, 2024

Conversation

LinuxSuRen
Copy link
Contributor

What's changed?

Below is the test result

image

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

Copy link
Contributor

@yuluo-yx yuluo-yx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuluo-yx
Copy link
Contributor

yuluo-yx commented Sep 5, 2024

ptal @tomsun28 @zqr10159

Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 lgtm

@Calvin979
Copy link
Contributor

How about use ResponseBodyAdvice to handle response entity globally? @tomsun28 @LinuxSuRen

@LinuxSuRen
Copy link
Contributor Author

I'm not sure if all controllers could have the same or similar way to handle it.

@tomsun28
Copy link
Contributor

tomsun28 commented Sep 6, 2024

+1 the response stru may not always same

@tomsun28 tomsun28 merged commit 98354f2 into apache:master Sep 6, 2024
3 checks passed
@LinuxSuRen LinuxSuRen deleted the chore/response-util branch September 6, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants