Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add more unit tests for some services #2653

Merged
merged 9 commits into from
Sep 3, 2024
Merged

test: add more unit tests for some services #2653

merged 9 commits into from
Sep 3, 2024

Conversation

LinuxSuRen
Copy link
Contributor

What's changed?

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@LinuxSuRen
Copy link
Contributor Author

fixed, see the screenshots

image

yuluo-yx
yuluo-yx approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@yuluo-yx yuluo-yx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuluo-yx yuluo-yx merged commit 86ca715 into apache:master Sep 3, 2024
3 checks passed
@LinuxSuRen LinuxSuRen deleted the test/ut branch September 4, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuluo-yx yuluo-yx yuluo-yx approved these changes

Assignees
No one assigned
Labels
backend collector
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LinuxSuRen @yuluo-yx @Calvin979 @Aias00