Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task][OSPP] HertzBeat Official Template Marketplace #2641

Merged
merged 66 commits into from
Oct 30, 2024

Conversation

All-The-Best-for
Copy link
Contributor

@All-The-Best-for All-The-Best-for commented Aug 30, 2024

What's changed?

#1792

I have built front-end and back-end projects for the template market, implementing functions such as template upload, search , view, share, download, version management, version updates, user login and registration, basic authentication, as well as personal center collection management and asset management. I have also tested key methods and functions.

The follow-up plan is to expand template description information and backend management, and improve overall logic.

image
image
image
image
image
image
image
image
image
image

Checklist

  • Use Java17, springboot3 to write back-end code, Angular to write front-end code.
  • realize the user personal page registration, login, upload templates.
  • realize yml template file search, download, share function (no need to log in).
  • template page to display the downloads, classification, template version.

@github-actions github-actions bot added the doc Improvements or additions to documentation label Aug 30, 2024
@All-The-Best-for All-The-Best-for changed the title first [Task][OSPP] HertzBeat Official Template Marketplace:first Aug 30, 2024
Copy link
Contributor

@Calvin979 Calvin979 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add apache license header in each file.

@zqr10159 zqr10159 marked this pull request as draft September 4, 2024 08:49
@github-actions github-actions bot removed the webapp label Oct 24, 2024
@All-The-Best-for
Copy link
Contributor Author

@All-The-Best-for https://github.com/apache/hertzbeat/actions/runs/11231101389/job/31219804763?pr=2641 Please add a license header to the files that need to add a license, and delete the extra font files

Hi, license have now been added to all files

@All-The-Best-for
Copy link
Contributor Author

Please add apache license header in each file.

Hi, license have now been added to all files

@tomsun28
Copy link
Contributor

lgtm! 👍 well done. btw, application.properties and application.yml seem duplicate, please remove application.properties

@All-The-Best-for
Copy link
Contributor Author

lgtm! 👍 well done. btw, application.properties and application.yml seem duplicate, please remove application.properties

Oh, yeah! I'll fix that.


import java.util.List;

public interface TemplateDao extends JpaRepository<Template, Integer> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can refer : org.apache.hertzbeat.manager.dao.MonitorDao ,use JpaSpecificationExecutor to avoid sql.

templatehub/src/main/resources/application.properties Outdated Show resolved Hide resolved
@GeneratedValue(strategy = GenerationType.IDENTITY)
private Integer id;

@Column(name = "user_id",nullable = false)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All commas need to be followed by a space, which is good practice

private String description;

@Column(nullable = false,name = "create_time")
private byte[] createTime;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can refer org.apache.hertzbeat.common.entity.alerter.Alert, use @EntityListeners(AuditingEntityListener.class) @CreatedBy @LastModifiedDate @LastModifiedBy @CreatedDate and so on


server.address=localhost

spring.application.name=hetzbeat-template-hub
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Misspelled words, and please use yml file


<dependency>
<groupId>com.alibaba</groupId>
<artifactId>druid-spring-boot-starter</artifactId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove redundant druid dependency


<dependency>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-data-jpa</artifactId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zqr10159 zqr10159 merged commit bff7575 into apache:master Oct 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Improvements or additions to documentation good first pull request Good for newcomers OSPP
Projects
Development

Successfully merging this pull request may close these issues.

6 participants