-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Task][OSPP] HertzBeat Official Template Marketplace #2641
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add apache license header
in each file.
Hi, license have now been added to all files |
Hi, license have now been added to all files |
lgtm! 👍 well done. btw, application.properties and application.yml seem duplicate, please remove application.properties |
Oh, yeah! I'll fix that. |
|
||
import java.util.List; | ||
|
||
public interface TemplateDao extends JpaRepository<Template, Integer> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can refer : org.apache.hertzbeat.manager.dao.MonitorDao
,use JpaSpecificationExecutor
to avoid sql.
@GeneratedValue(strategy = GenerationType.IDENTITY) | ||
private Integer id; | ||
|
||
@Column(name = "user_id",nullable = false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All commas need to be followed by a space, which is good practice
private String description; | ||
|
||
@Column(nullable = false,name = "create_time") | ||
private byte[] createTime; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can refer org.apache.hertzbeat.common.entity.alerter.Alert
, use @EntityListeners(AuditingEntityListener.class)
@CreatedBy
@LastModifiedDate
@LastModifiedBy
@CreatedDate
and so on
|
||
server.address=localhost | ||
|
||
spring.application.name=hetzbeat-template-hub |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Misspelled words, and please use yml file
|
||
<dependency> | ||
<groupId>com.alibaba</groupId> | ||
<artifactId>druid-spring-boot-starter</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove redundant druid dependency
|
||
<dependency> | ||
<groupId>org.springframework.boot</groupId> | ||
<artifactId>spring-boot-starter-data-jpa</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refer to the configuration of the main program
https://github.com/apache/hertzbeat/blob/master/manager/src/main/resources/application.yml
What's changed?
#1792
I have built front-end and back-end projects for the template market, implementing functions such as template upload, search , view, share, download, version management, version updates, user login and registration, basic authentication, as well as personal center collection management and asset management. I have also tested key methods and functions.
The follow-up plan is to expand template description information and backend management, and improve overall logic.
Checklist