Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve] add IcmpCollectImplTest #2033

Merged
merged 2 commits into from
May 26, 2024
Merged

[improve] add IcmpCollectImplTest #2033

merged 2 commits into from
May 26, 2024

Conversation

zuobiao-zhou
Copy link
Member

What's changed?

Add unit test for IcmpCollectImpl.

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

@tomsun28 tomsun28 added the good first pull request Good for newcomers label May 26, 2024
tomsun28
tomsun28 approved these changes May 26, 2024
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tomsun28 tomsun28 merged commit 49ebdfb into apache:master May 26, 2024
3 checks passed
@zuobiao-zhou zuobiao-zhou deleted the icmpCollectTest branch May 26, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
backend collector good first pull request Good for newcomers
Projects
Apache HertzBeat (Incubating)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zuobiao-zhou @tomsun28