Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve] http protocol prometheus parsing optimization #1996

Merged
merged 3 commits into from
May 16, 2024

Conversation

zhangshenghang
Copy link
Member

@zhangshenghang zhangshenghang commented May 16, 2024

What's changed?

#1992

  • Prometheus parsing SUMMARY and HISTOGRAM type data parsing support under HTTP protocol
  • Prometheus parses monitoring indicator names under HTTP protocol and displays them on the page
  • Updated ExporterParserTest test class
  • Some Chinese comments translated into English

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Monitoring metic display name

# TYPE log4j2_appender counter
log4j2_appender_total{cluster="standalone",level="debug"} 0.0
log4j2_appender_created{cluster="standalone",level="debug"} 1.715842133768E9
log4j2_appender_total{cluster="standalone",level="warn"} 12.0
log4j2_appender_created{cluster="standalone",level="warn"} 1.715842133768E9
log4j2_appender_total{cluster="standalone",level="trace"} 0.0
log4j2_appender_created{cluster="standalone",level="trace"} 1.715842133768E9
log4j2_appender_total{cluster="standalone",level="error"} 7.0
log4j2_appender_created{cluster="standalone",level="error"} 1.715842133768E9
log4j2_appender_total{cluster="standalone",level="fatal"} 0.0
log4j2_appender_created{cluster="standalone",level="fatal"} 1.715842133768E9
log4j2_appender_total{cluster="standalone",level="info"} 660.0
log4j2_appender_created{cluster="standalone",level="info"} 1.715842133768E9
image

histogram type data

# TYPE pulsar_metadata_store_ops_latency_ms histogram
pulsar_metadata_store_ops_latency_ms_bucket{cluster="standalone",name="metadata-store",type="get",status="success",le="1.0"} 59.0
pulsar_metadata_store_ops_latency_ms_bucket{cluster="standalone",name="metadata-store",type="get",status="success",le="3.0"} 61.0
pulsar_metadata_store_ops_latency_ms_bucket{cluster="standalone",name="metadata-store",type="get",status="success",le="5.0"} 61.0
pulsar_metadata_store_ops_latency_ms_bucket{cluster="standalone",name="metadata-store",type="get",status="success",le="10.0"} 61.0
pulsar_metadata_store_ops_latency_ms_bucket{cluster="standalone",name="metadata-store",type="get",status="success",le="20.0"} 61.0
pulsar_metadata_store_ops_latency_ms_bucket{cluster="standalone",name="metadata-store",type="get",status="success",le="50.0"} 61.0
pulsar_metadata_store_ops_latency_ms_bucket{cluster="standalone",name="metadata-store",type="get",status="success",le="100.0"} 61.0
pulsar_metadata_store_ops_latency_ms_bucket{cluster="standalone",name="metadata-store",type="get",status="success",le="200.0"} 61.0
pulsar_metadata_store_ops_latency_ms_bucket{cluster="standalone",name="metadata-store",type="get",status="success",le="500.0"} 61.0

image

summary type data

# TYPE pulsar_resource_group_aggregate_usage_secs summary
pulsar_resource_group_aggregate_usage_secs{cluster="standalone",quantile="0.5"} 2.69245E-4
pulsar_resource_group_aggregate_usage_secs{cluster="standalone",quantile="0.9"} 3.49601E-4
pulsar_resource_group_aggregate_usage_secs_count{cluster="standalone"} 13.0
pulsar_resource_group_aggregate_usage_secs_sum{cluster="standalone"} 0.004832498
pulsar_resource_group_aggregate_usage_secs_created{cluster="standalone"} 1.715842140749E9
image

@tomsun28 tomsun28 added the good first pull request Good for newcomers label May 16, 2024
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!👍

@tomsun28 tomsun28 merged commit 479b454 into apache:master May 16, 2024
3 checks passed
@zhangshenghang zhangshenghang deleted the improve-metric-name-display branch September 3, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants