[feature] add at function for wechat #1994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove required fill Signed-off-by: linDong <56677297@qq.com>
|
@tomsun28 cr ，please |
tomsun28
changed the title
...a/org/apache/hertzbeat/manager/component/alerter/impl/WeWorkRobotAlertNotifyHandlerImpl.java
Outdated
Show resolved
Hide resolved
...a/org/apache/hertzbeat/manager/component/alerter/impl/WeWorkRobotAlertNotifyHandlerImpl.java
Outdated
Show resolved
Hide resolved
|
Code checkstyle is failed, please refer to here and ensure it passes the local test first. |
gjjjj0101
reviewed
May 16, 2024
...a/org/apache/hertzbeat/manager/component/alerter/impl/WeWorkRobotAlertNotifyHandlerImpl.java
Show resolved
Hide resolved
tomsun28
reviewed
May 17, 2024
web-app/src/assets/i18n/en-US.json
Outdated
| @@ -271,6 +271,7 @@ | |||
| "alert.notice.type.wechat-id": "WeChat OPENID", | |||
| "alert.notice.type.wework": "WeWork Robot", | |||
| "alert.notice.type.wework-key": "WeWork Robot KEY", | |||
| "alert.notice.type.wework-userId": "userId", | |||
There was a problem hiding this comment.
Suggested change
| "alert.notice.type.wework-userId": "userId", | |
| "alert.notice.type.wework-userId": "UserId", |
tomsun28
reviewed
May 17, 2024
| @@ -271,6 +271,7 @@ | |||
| "alert.notice.type.wechat-id": "微信OPENID", | |||
| "alert.notice.type.wework": "企业微信机器人", | |||
| "alert.notice.type.wework-key": "企业微信机器人KEY", | |||
| "alert.notice.type.wework-userId": "用户id", | |||
There was a problem hiding this comment.
hi, the i18n zh-TW.json also need this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added enterprise weChat robot @ function