[fix] Compatible with MongoDB versions earlier than 3.6 #1988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } else { | ||
| document = mongoDatabase.runCommand(clientSession, new Document(command, 1)); | ||
| document = mongoDatabase.runCommand(new Document(command, 1)); |
There was a problem hiding this comment.
Why not combine lines 123 and 125 into one line and put it outside the if statement?
There was a problem hiding this comment.
Thanks, I refactor it.
tomsun28
reviewed
May 14, 2024
| CollectRep.ValueRow.Builder valueRowBuilder = CollectRep.ValueRow.newBuilder(); | ||
| Document document; | ||
| if (metricsParts.length == 1) { | ||
| document = mongoDatabase.runCommand(clientSession, new Document(command, 1)); |
There was a problem hiding this comment.
hi, if do not use clientSession close, is the mongoDatabase will auto close the seesion after run command?
There was a problem hiding this comment.
mongoDatabase is used to encapsulate the functions for users to operate the database, and construct the real execution options and hand it over to mongoClient for execution, so it does not need to close.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
link #1692
Checklist
Add or update API