Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve] clean up home webapp unused code #1915

Merged
merged 21 commits into from
May 5, 2024
Merged

[improve] clean up home webapp unused code #1915

merged 21 commits into from
May 5, 2024

Conversation

tomsun28
Copy link
Contributor

@tomsun28 tomsun28 commented May 4, 2024

What's changed?

clean up home webapp unused code

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@github-actions github-actions bot added doc Improvements or additions to documentation backend e2e webapp home labels May 4, 2024
@tomsun28
add web-app/src/app/routes/exception in license
1d3aedb 
Signed-off-by: tomsun28 <tomsun28@outlook.com>
@tomsun28
add refer from
52d7c9d 
Signed-off-by: tomsun28 <tomsun28@outlook.com>
@tomsun28
Add @Aias00 as a contributor
f7c8c6b
@tomsun28
Add @westboy as a contributor
24902df
@tomsun28
update
b9dfe03 
Signed-off-by: tomsun28 <tomsun28@outlook.com>
@tomsun28
update
0b2ba7e 
Signed-off-by: tomsun28 <tomsun28@outlook.com>
@tomsun28
update
a349799 
Signed-off-by: tomsun28 <tomsun28@outlook.com>
ZY945
ZY945 previously approved these changes May 5, 2024
View reviewed changes
Copy link
Member

@ZY945 ZY945 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👍

yuluo-yx
yuluo-yx approved these changes May 5, 2024
View reviewed changes
Copy link
Contributor

@yuluo-yx yuluo-yx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

TJxiaobao
TJxiaobao previously approved these changes May 5, 2024
View reviewed changes
Copy link
Contributor

@TJxiaobao TJxiaobao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👍

@tomsun28
update
e8f2ef9 
Signed-off-by: tomsun28 <tomsun28@outlook.com>
@tomsun28
update
4e7d552 
Signed-off-by: tomsun28 <tomsun28@outlook.com>
@tomsun28
update
ddc4a08 
Signed-off-by: tomsun28 <tomsun28@outlook.com>
@tomsun28
update
cb314f9 
Signed-off-by: tomsun28 <tomsun28@outlook.com>
@tomsun28
update
d605f42 
Signed-off-by: tomsun28 <tomsun28@outlook.com>
@tomsun28
update release doc
fe242af
@tomsun28 tomsun28 dismissed stale reviews from TJxiaobao and ZY945 via fe242af May 5, 2024 07:23
@TJxiaobao TJxiaobao merged commit 30eeed0 into master May 5, 2024
4 checks passed
@TJxiaobao TJxiaobao deleted the clean-home branch July 17, 2024 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuluo-yx yuluo-yx yuluo-yx approved these changes

@TJxiaobao TJxiaobao TJxiaobao approved these changes

@ZY945 ZY945 ZY945 left review comments

@a-little-fool a-little-fool Awaiting requested review from a-little-fool

Assignees
No one assigned
Labels
backend doc Improvements or additions to documentation docker e2e home infra license script webapp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tomsun28 @ZY945 @yuluo-yx @TJxiaobao