Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(*): fix TdEngine Init not found Database #1891

Merged
merged 2 commits into from
May 7, 2024
Merged

fix(*): fix TdEngine Init not found Database #1891

merged 2 commits into from
May 7, 2024

Conversation

Clownsw
Copy link
Contributor

@Clownsw Clownsw commented Apr 30, 2024 •
edited
Loading

What's changed?

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@Clownsw Clownsw force-pushed the fix/tdengine-init-failed branch 3 times, most recently from 9ef7cf6 to 842ea15 Compare May 4, 2024 04:37
@Clownsw
Copy link
Contributor Author

Clownsw commented May 4, 2024 •
edited
Loading

Replacing handwritten parsing with tdengine official Driver jdbc url parsing @tomsun28

@zqr10159 zqr10159 requested a review from tomsun28 May 7, 2024 00:05
@github-actions github-actions bot added doc Improvements or additions to documentation script labels May 7, 2024
@Clownsw
fix(*): fix TdEngine Init not found Database
1c0c3d6 
Signed-off-by: Clownsw <msmliexx1@gmail.com>
@github-actions github-actions bot removed doc Improvements or additions to documentation script labels May 7, 2024
@Clownsw
Copy link
Contributor Author

Clownsw commented May 7, 2024

I removed the useless initialization result return

tomsun28
tomsun28 approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍LGTM

@tomsun28 tomsun28 added the good first pull request Good for newcomers label May 7, 2024
@tomsun28 tomsun28 merged commit 492b89f into apache:master May 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
backend good first pull request Good for newcomers
Projects
Apache HertzBeat (Incubating)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Clownsw @tomsun28