Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improve]When multiple lines are returned, each alarm is triggered instead of only the first alarm #1797

Merged
merged 3 commits into from
Apr 21, 2024
Merged

[Improve]When multiple lines are returned, each alarm is triggered instead of only the first alarm #1797

merged 3 commits into from
Apr 21, 2024

Conversation

15613060203
Copy link
Contributor

When multiple lines are returned, each alarm is triggered instead of only the first alarm

@tomsun28 tomsun28 added the good first pull request Good for newcomers label Apr 20, 2024
@tomsun28 tomsun28 self-requested a review April 20, 2024 15:48
tomsun28
tomsun28 approved these changes Apr 21, 2024
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！Btw, can you help add some unit test for alarm calculate, feel this is very important for alarm module.

@tomsun28 tomsun28 merged commit 5e155e0 into apache:master Apr 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
backend good first pull request Good for newcomers
Projects
Apache HertzBeat (Incubating)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@15613060203 @tomsun28