Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve]Add external lib folder to store mysql and oracle driver. #1783

Merged
merged 11 commits into from
Apr 21, 2024
Merged

[improve]Add external lib folder to store mysql and oracle driver. #1783

merged 11 commits into from
Apr 21, 2024

Conversation

zqr10159
Copy link
Member

What's changed?

[improve]Add external lib folder to store mysql and oracle driver.

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@tomsun28 tomsun28 added the good first pull request Good for newcomers label Apr 19, 2024
@tomsun28
remove other mysql version
3a7353c 
Signed-off-by: tomsun28 <tomsun28@outlook.com>
@tomsun28 tomsun28 self-requested a review April 19, 2024 11:58
@tomsun28
Copy link
Contributor

👍👍👍 hi the collector also need when collecter startup standalone, and the docker startup shell entrypoint.sh

@zqr10159
Copy link
Member Author

zqr10159 commented Apr 20, 2024 •
edited
Loading

👍👍👍 hi the collector also need when collecter startup standalone, and the docker startup shell entrypoint.sh

Already updated.

@zqr10159 zqr10159 linked an issue Apr 20, 2024 that may be closed by this pull request
[Task] <support auto load mysql oracle jar from extern path> #1777
Closed
@tomsun28 tomsun28 added this to the 1.6.0 milestone Apr 20, 2024
@tomsun28
fix local mvn test error
7cc3239 
Signed-off-by: tomsun28 <tomsun28@outlook.com>
@tomsun28
Copy link
Contributor

I have test startup.sh shutdown.sh mysql-monitoring in mac, linux, work successed!

@tomsun28
Merge branch 'master' into external-jdbc
637dfa1
@tomsun28
move the ext-lib
cdb3b7c 
Signed-off-by: tomsun28 <tomsun28@outlook.com>
tomsun28
tomsun28 approved these changes Apr 21, 2024
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!👍

@tomsun28 tomsun28 merged commit 0d17a47 into master Apr 21, 2024
3 checks passed
@zqr10159 zqr10159 deleted the external-jdbc branch September 23, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
backend build good first pull request Good for newcomers script
Projects
Apache HertzBeat (Incubating)
Status: Done
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.

[Task] <support auto load mysql oracle jar from extern path>
2 participants
@zqr10159 @tomsun28