Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary if-else statement. #1770

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Remove unnecessary if-else statement. #1770

merged 2 commits into from
Apr 18, 2024

Conversation

dukbong
Copy link
Contributor

@dukbong dukbong commented Apr 18, 2024

What's changed?

Removing unnecessary if-else statements

  • Additional Note: Upon examining the code flow, I noticed that the parameters could be null, but I confirmed that null checks are already performed earlier in the code. Therefore, additional null checks are not necessary.

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

tomsun28
tomsun28 approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tomsun28 tomsun28 merged commit 7ca110e into apache:master Apr 18, 2024
3 checks passed
@dukbong dukbong deleted the ifelse branch April 18, 2024 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
backend collector
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dukbong @tomsun28