Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete the code comment translation of the common module #1766

Merged
merged 4 commits into from
Apr 18, 2024
Merged

Complete the code comment translation of the common module #1766

merged 4 commits into from
Apr 18, 2024

Conversation

Hi-Mr-Wind
Copy link
Contributor

Complete the code comment translation of the common module

Checklist

  • [ √] I have read the Contributing Guide
  • [√ ] I have written the necessary doc or comment.
  • [√ ] I have added the necessary unit tests and all cases have passed.

Add or update API

  • [ √] I have added the necessary e2e tests and all cases have passed.

@tomsun28 tomsun28 added the good first pull request Good for newcomers label Apr 17, 2024
@tomsun28
Copy link
Contributor

hi, there are some check error please fix

[INFO] Starting audit...
Error:  /home/runner/work/hertzbeat/hertzbeat/common/src/main/java/org/apache/hertzbeat/common/entity/alerter/AlertSilence.java:101: Line is longer than 200 characters (found 226). [LineLength]
Error:  /home/runner/work/hertzbeat/hertzbeat/common/src/main/java/org/apache/hertzbeat/common/entity/manager/NoticeReceiver.java:68: Line is longer than 200 characters (found 246). [LineLength]
Error:  /home/runner/work/hertzbeat/hertzbeat/common/src/main/java/org/apache/hertzbeat/common/entity/manager/NoticeTemplate.java:71: Line is longer than 200 characters (found 246). [LineLength]
Error:  /home/runner/work/hertzbeat/hertzbeat/common/src/main/java/org/apache/hertzbeat/common/entity/manager/NoticeRule.java:102: Line is longer than 200 characters (found 203). [LineLength]
Audit done.

@Hi-Mr-Wind
Copy link
Contributor Author

ok I'll fix it

tomsun28
tomsun28 approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍👍

@tomsun28 tomsun28 merged commit d6ce092 into apache:master Apr 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
backend good first pull request Good for newcomers
Projects
Apache HertzBeat (Incubating)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hi-Mr-Wind @tomsun28