Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] fix statuspage index exception #1747

Merged
merged 1 commit into from
Apr 15, 2024
Merged

[bugfix] fix statuspage index exception #1747

merged 1 commit into from
Apr 15, 2024

Conversation

makechoicenow
Copy link
Contributor

What's changed?

Fix this issue: #1702

Return a default empty StatusPageHistory when statusPageHistories size is 0

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@tomsun28 tomsun28 linked an issue Apr 15, 2024 that may be closed by this pull request
[BUG]"Status page error" #1702
Closed
1 task
tomsun28
tomsun28 approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tomsun28 tomsun28 changed the title Fix Statuspage Index exception [bugfix] fix statuspage index exception Apr 15, 2024
@tomsun28 tomsun28 merged commit e063508 into apache:master Apr 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
bugfix good first pull request Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]"Status page error"
2 participants
@makechoicenow @tomsun28