Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fixed] fixed click collector online offline button error #1734

Merged
merged 1 commit into from
Apr 14, 2024

Conversation

miki-hmt
Copy link
Contributor

@miki-hmt miki-hmt commented Apr 12, 2024

What's changed?

When you click the collection cluster menu to perform offline and online operations on the collector, a window will pop up to prompt interface 404, because there is an “/” in front of the calling interface/online/and/offline/interface in the collector.service.ts code, and these two interfaces are removed here “/”

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@tomsun28 tomsun28 changed the title [fixed] fixed click collector online&offline button error [fixed] fixed click collector online offline button error Apr 12, 2024
@tomsun28 tomsun28 added enhancement New feature or request good first pull request Good for newcomers bugfix labels Apr 12, 2024
Copy link
Contributor

@a-little-fool a-little-fool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@a-little-fool a-little-fool merged commit 37a2323 into apache:master Apr 14, 2024
1 check passed
@tomsun28
Copy link
Contributor

@all-contributors please add @miki-hmt for code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix enhancement New feature or request good first pull request Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] When clicking the offline and online collector button, the pop-up window is abnormal.
4 participants