Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: support monitoring nginx metrics and add a help doc #1420

Merged
merged 3 commits into from
Dec 14, 2023
Merged

feature: support monitoring nginx metrics and add a help doc #1420

merged 3 commits into from
Dec 14, 2023

Conversation

a-little-fool
Copy link
Contributor

What's changed?

support monitoring nginx metrics

Checklist

  • [✅] I hereby agree to the terms of the HertzBeat CLA
  • [✅] I have read the Contributing Guide
  • [✅] I have written the necessary doc or comment.
  • [✅] I have added the necessary unit tests and all cases have passed.

Add or update API

  • [✅] I have added the necessary e2e tests and all cases have passed.

@tomsun28 tomsun28 added enhancement New feature or request good first pull request Good for newcomers new feature labels Dec 14, 2023
@tomsun28 tomsun28 added this to the 1.4.4 milestone Dec 14, 2023
tomsun28
tomsun28 approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 👍👍

@tomsun28 tomsun28 merged commit 56ca0a7 into apache:master Dec 14, 2023
2 checks passed
@a-little-fool a-little-fool deleted the support-nginx-metrics-collect branch December 14, 2023 14:18
tomsun28 pushed a commit that referenced this pull request Jan 16, 2024
@a-little-fool @tomsun28
feature: support monitoring nginx metrics and add a help doc (#1420)
374961f
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
@a-little-fool
feature: support monitoring nginx metrics and add a help doc (#1420)
d1e1bb7
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
@a-little-fool
feature: support monitoring nginx metrics and add a help doc (#1420)
76d5f00
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
@a-little-fool
feature: support monitoring nginx metrics and add a help doc (#1420)
cb8bdbe
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
@a-little-fool @tomsun28
feature: support monitoring nginx metrics and add a help doc (#1420)
c0fa613
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@a-little-fool
feature: support monitoring nginx metrics and add a help doc (#1420)
0a62b84
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@a-little-fool
feature: support monitoring nginx metrics and add a help doc (#1420)
85077f2
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@a-little-fool
feature: support monitoring nginx metrics and add a help doc (#1420)
b85b0b2
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@a-little-fool
feature: support monitoring nginx metrics and add a help doc (#1420)
405b882
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request good first pull request Good for newcomers new feature
Projects
None yet
Milestone
1.4.4
Development

Successfully merging this pull request may close these issues.
2 participants
@a-little-fool @tomsun28