-
Notifications
You must be signed in to change notification settings - Fork 10
fix(ci): let ci check go-lint and remove go-lint in Dockerfile #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
In additional, fix the typo errors in Dockerfile
hi The Dockefile has been restored to its previous state. Please check it again. Additionally, I think golint should be placed after go test and build because they have a sequence relationship. For example, after golint is executed, test and build are performed. Placing it as a linter seems inappropriate. WDYT? |
Yeah, you are right! Put the golint before go test and go build in workflow |
I see the go-lint action is commented now, are there some reasons? hertzbeat-collector-go/.github/workflows/build-and-test.yml Lines 26 to 35 in d627247
|
emm~ maybe because it has many lint error? |
ARG GOPROXY | ||
# ENV GOPROXY ${GOPROXY:-direct} | ||
# ENV GOPROXY=https://proxy.golang.com.cn,direct | ||
ENV GOPROXY ${GOPROXY:-direct} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这是可选的,Github 上并不需要此配置。可以恢复下
In additional, fix the typo errors in Dockerfile. I remove the unused tool
golangci-lint
.