Skip to content

Conversation

yexuanyang
Copy link
Contributor

In additional, fix the typo errors in Dockerfile. I remove the unused tool golangci-lint.

In additional, fix the typo errors in Dockerfile
@yuluo-yx
Copy link
Member

hi The Dockefile has been restored to its previous state. Please check it again. Additionally, I think golint should be placed after go test and build because they have a sequence relationship. For example, after golint is executed, test and build are performed. Placing it as a linter seems inappropriate. WDYT?

@yexuanyang
Copy link
Contributor Author

Yeah, you are right! Put the golint before go test and go build in workflow 🛠️ Build and Test is better.

@yexuanyang
Copy link
Contributor Author

I see the go-lint action is commented now, are there some reasons?

jobs:
Build:
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
- uses: ./tools/github-actions/setup-deps
- run: make fmt
# todo: 暂时关闭
# - run: make go-lint
- run: make build

@yuluo-yx
Copy link
Member

I see the go-lint action is commented now, are there some reasons?

jobs:
Build:
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
- uses: ./tools/github-actions/setup-deps
- run: make fmt
# todo: 暂时关闭
# - run: make go-lint
- run: make build

emm~ maybe because it has many lint error?

ARG GOPROXY
# ENV GOPROXY ${GOPROXY:-direct}
# ENV GOPROXY=https://proxy.golang.com.cn,direct
ENV GOPROXY ${GOPROXY:-direct}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这是可选的,Github 上并不需要此配置。可以恢复下

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants