HBASE-23604: Clarify AsyncRegistry usage in the code. #957

bharathv · 2019-12-20T23:38:17Z

This patch is a simple refactor that renames a bunch of classes
to add more context to the readers. The code is littered with
the usage of word "registry" but it is not clear what the registry
is all about. This patch renames a bunch of classes to make it
more self explanatory.

Apache-HBase · 2019-12-21T06:11:19Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 24s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 23 new or modified test files.
		_ HBASE-18095/client-locate-meta-no-zookeeper Compile Tests _
+0 🆗	mvndep	0m 34s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 43s	HBASE-18095/client-locate-meta-no-zookeeper passed
+1 💚	compile	1m 25s	HBASE-18095/client-locate-meta-no-zookeeper passed
+1 💚	checkstyle	2m 3s	HBASE-18095/client-locate-meta-no-zookeeper passed
+1 💚	shadedjars	5m 4s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 5s	HBASE-18095/client-locate-meta-no-zookeeper passed
+0 🆗	spotbugs	4m 52s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	6m 1s	HBASE-18095/client-locate-meta-no-zookeeper passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 31s	the patch passed
+1 💚	compile	1m 24s	the patch passed
+1 💚	javac	1m 24s	the patch passed
-1 ❌	checkstyle	0m 34s	hbase-client: The patch generated 35 new + 15 unchanged - 1 fixed = 50 total (was 16)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedjars	5m 6s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	17m 40s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚	javadoc	0m 59s	the patch passed
+1 💚	findbugs	6m 13s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 51s	hbase-client in the patch passed.
-1 ❌	unit	313m 25s	hbase-server in the patch failed.
+1 💚	asflicense	0m 55s	The patch does not generate ASF License warnings.
		386m 0s

Reason	Tests
Failed junit tests	hadoop.hbase.master.procedure.TestSCPWithReplicas
	hadoop.hbase.master.TestSplitWALManager
	hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
	hadoop.hbase.master.TestAssignmentManagerMetrics
	hadoop.hbase.client.TestFromClientSide3

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-957/1/artifact/out/Dockerfile
GITHUB PR	#957
JIRA Issue	HBASE-23604
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux c2ad08fb052e 4.15.0-70-generic #79-Ubuntu SMP Tue Nov 12 10:36:11 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-957/out/precommit/personality/provided.sh
git revision	HBASE-18095/client-locate-meta-no-zookeeper / `e41b46c`
Default Java	1.8.0_181
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-957/1/artifact/out/diff-checkstyle-hbase-client.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-957/1/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-957/1/testReport/
Max. process+thread count	4849 (vs. ulimit of 10000)
modules	C: hbase-client hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-957/1/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

saintstack

Ok, if you think too that 'registry' is too generic. I don't want to make work for you.

Looking at this patch, you go from Registry to MetaRegistry.

'meta' is a loaded term in hbase and in particular, usually refers to the meta table.

This registry has clusterid, meta region location, and what is active master (currently) which are 'meta' attributes of the cluster... true, but it strikes me that MetaRegistry is as generic as Registry and in fact because of the overload on meta, and that the Registry currently has three disparate attributes that include meta locations, I think Registry better than MetaRegistry (yikes).

There are some good changes in this patch -- the getActiveMasters and making meta locations plural. Get them in? And meantime we all 'learn' what Registry is about...

Unless there a better name for it? (ClusterRegistry, ClusterAttributes...)

hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncConnectionImpl.java

saintstack · 2019-12-21T15:23:50Z

hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncConnectionMetaRegistry.java

   */
-  CompletableFuture<RegionLocations> getMetaRegionLocation();
+  CompletableFuture<RegionLocations> getMetaRegionLocations();


This is good.

bharathv · 2019-12-21T18:09:32Z

'meta' is a loaded term in hbase and in particular, usually refers to the meta table.

That is a fair point. There are definitely other connotations for the word "meta" in this project and readers might get confused even more.

There are some good changes in this patch -- the getActiveMasters and making meta locations plural. Get them in? And meantime we all 'learn' what Registry is about...

Ya. I can't think of a good name yet, without the use of word meta. (ConnectionRegistry?). I'm undoing the class renames and (force) pushing the change again. May be we can revisit later.

Apache-HBase · 2019-12-21T22:27:09Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 32s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 6 new or modified test files.
		_ HBASE-18095/client-locate-meta-no-zookeeper Compile Tests _
+0 🆗	mvndep	0m 36s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 19s	HBASE-18095/client-locate-meta-no-zookeeper passed
+1 💚	compile	1m 21s	HBASE-18095/client-locate-meta-no-zookeeper passed
+1 💚	checkstyle	1m 51s	HBASE-18095/client-locate-meta-no-zookeeper passed
+1 💚	shadedjars	4m 42s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 59s	HBASE-18095/client-locate-meta-no-zookeeper passed
+0 🆗	spotbugs	4m 28s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	5m 31s	HBASE-18095/client-locate-meta-no-zookeeper passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 0s	the patch passed
+1 💚	compile	1m 22s	the patch passed
+1 💚	javac	1m 22s	the patch passed
+1 💚	checkstyle	0m 33s	hbase-client: The patch generated 0 new + 14 unchanged - 1 fixed = 14 total (was 15)
+1 💚	checkstyle	1m 16s	The patch passed checkstyle in hbase-server
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedjars	4m 38s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	15m 56s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚	javadoc	1m 0s	the patch passed
+1 💚	findbugs	5m 43s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 52s	hbase-client in the patch passed.
-1 ❌	unit	180m 32s	hbase-server in the patch failed.
+1 💚	asflicense	1m 6s	The patch does not generate ASF License warnings.
		246m 51s

Reason	Tests
Failed junit tests	hadoop.hbase.master.assignment.TestOpenRegionProcedureHang
	hadoop.hbase.regionserver.TestSplitTransactionOnCluster
	hadoop.hbase.quotas.TestQuotaAdmin

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-957/2/artifact/out/Dockerfile
GITHUB PR	#957
JIRA Issue	HBASE-23604
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux b4ef8b6d0fd4 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-957/out/precommit/personality/provided.sh
git revision	HBASE-18095/client-locate-meta-no-zookeeper / `e41b46c`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-957/2/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-957/2/testReport/
Max. process+thread count	4627 (vs. ulimit of 10000)
modules	C: hbase-client hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-957/2/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

saintstack

LGTM.

Where should I merge?

I like ConnectionRegistry.

saintstack · 2019-12-27T20:15:48Z

i.e. you need the Registry to make a useful Connection to the cluster.

bharathv · 2019-12-27T20:24:07Z

Thanks for the review.

i.e. you need the Registry to make a useful Connection to the cluster.

Yea, that seems meaningful and simple enough to me as well. Will do a follow up.

Where should I merge?

Can you please merge this into the feature branch? 'HBASE-18095/client-locate-meta-no-zookeeper'. While you are here, can you please rebase the feature branch with latest master? I checked that the rebase is clean but I don't have the push rights.

bharathv · 2019-12-27T23:37:47Z

@saintstack I also pushed a commit that does the rename of AsyncRegistry -> ConnectionRegistry. Let me know what you think. I thought it'd be good to push both the commits together.

Apache-HBase · 2019-12-28T06:18:43Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	3m 55s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 23 new or modified test files.
		_ HBASE-18095/client-locate-meta-no-zookeeper Compile Tests _
+0 🆗	mvndep	0m 33s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 57s	HBASE-18095/client-locate-meta-no-zookeeper passed
+1 💚	compile	1m 23s	HBASE-18095/client-locate-meta-no-zookeeper passed
+1 💚	checkstyle	2m 3s	HBASE-18095/client-locate-meta-no-zookeeper passed
+1 💚	shadedjars	5m 5s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 4s	HBASE-18095/client-locate-meta-no-zookeeper passed
+0 🆗	spotbugs	4m 49s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	5m 57s	HBASE-18095/client-locate-meta-no-zookeeper passed
-0 ⚠️	patch	5m 4s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 33s	the patch passed
+1 💚	compile	1m 24s	the patch passed
+1 💚	javac	1m 24s	the patch passed
+1 💚	checkstyle	0m 32s	hbase-client: The patch generated 0 new + 14 unchanged - 2 fixed = 14 total (was 16)
-1 ❌	checkstyle	1m 27s	hbase-server: The patch generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedjars	5m 3s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	17m 48s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚	javadoc	0m 59s	the patch passed
+1 💚	findbugs	6m 15s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 51s	hbase-client in the patch passed.
-1 ❌	unit	321m 1s	hbase-server in the patch failed.
+1 💚	asflicense	0m 52s	The patch does not generate ASF License warnings.
		396m 19s

Reason	Tests
Failed junit tests	hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated
	hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient
	hadoop.hbase.client.TestAdmin2
	hadoop.hbase.master.TestSplitWALManager
	hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
	hadoop.hbase.regionserver.TestSplitTransactionOnCluster

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-957/3/artifact/out/Dockerfile
GITHUB PR	#957
JIRA Issue	HBASE-23604
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 073bd2f97bda 4.15.0-70-generic #79-Ubuntu SMP Tue Nov 12 10:36:11 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-957/out/precommit/personality/provided.sh
git revision	HBASE-18095/client-locate-meta-no-zookeeper / `e41b46c`
Default Java	1.8.0_181
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-957/3/artifact/out/diff-checkstyle-hbase-server.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-957/3/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-957/3/testReport/
Max. process+thread count	4894 (vs. ulimit of 10000)
modules	C: hbase-client hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-957/3/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

saintstack · 2019-12-28T19:25:31Z

I rebased for you. Why the conflict above do you think? And do you want to fix the checkstyle?

saintstack · 2019-12-28T19:26:39Z

I think the rename to ConnectionRegistry looks good.

bharathv

@saintstack Thanks for the rebase. I fixed the checkstyle issues, squashed the commits and rebased on top of the latest HEAD.

Apache-HBase · 2019-12-29T10:16:17Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 37s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 23 new or modified test files.
		_ HBASE-18095/client-locate-meta-no-zookeeper Compile Tests _
+0 🆗	mvndep	1m 55s	Maven dependency ordering for branch
+1 💚	mvninstall	6m 33s	HBASE-18095/client-locate-meta-no-zookeeper passed
+1 💚	compile	1m 23s	HBASE-18095/client-locate-meta-no-zookeeper passed
+1 💚	checkstyle	1m 54s	HBASE-18095/client-locate-meta-no-zookeeper passed
+1 💚	shadedjars	4m 44s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 5s	HBASE-18095/client-locate-meta-no-zookeeper passed
+0 🆗	spotbugs	4m 20s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	5m 32s	HBASE-18095/client-locate-meta-no-zookeeper passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 2s	the patch passed
+1 💚	compile	1m 23s	the patch passed
+1 💚	javac	1m 23s	the patch passed
+1 💚	checkstyle	0m 32s	hbase-client: The patch generated 0 new + 14 unchanged - 2 fixed = 14 total (was 16)
+1 💚	checkstyle	1m 16s	The patch passed checkstyle in hbase-server
+1 💚	whitespace	0m 1s	The patch has no whitespace issues.
+1 💚	shadedjars	4m 36s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	16m 5s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚	javadoc	0m 58s	the patch passed
+1 💚	findbugs	5m 50s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 2s	hbase-client in the patch passed.
-1 ❌	unit	163m 40s	hbase-server in the patch failed.
+1 💚	asflicense	0m 57s	The patch does not generate ASF License warnings.
		233m 21s

Reason	Tests
Failed junit tests	hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient
	hadoop.hbase.master.assignment.TestRegionReplicaSplit

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-957/4/artifact/out/Dockerfile
GITHUB PR	#957
JIRA Issue	HBASE-23604
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux f8a2f9161d66 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-957/out/precommit/personality/provided.sh
git revision	HBASE-18095/client-locate-meta-no-zookeeper / `1c41b36`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-957/4/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-957/4/testReport/
Max. process+thread count	4725 (vs. ulimit of 10000)
modules	C: hbase-client hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-957/4/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

bharathv · 2019-12-31T18:57:11Z

@saintstack Can you please merge this when you get a chance? Will rebase #954. Thanks for the reviews.

hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionRegistry.java

hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionRegistryFactory.java

ndimiduk · 2020-01-02T19:04:07Z

Thank you for making an effort to improve this class name. I also find it confusing for a first-read experience.

- Cleans up the method names to make more sense and adds a little more javadocs for context. In future patches we can revisit the name of the actual class to make it more self explanatory. - Does AsyncRegistry -> ConnectionRegistry rename. "async" ness of the registry is kind of implicit based on the interface contents and need not be reflected in the name.

bharathv · 2020-01-03T01:18:05Z

@saintstack / @ndimiduk I force pushed after rebasing on the latest HEAD. Can one of you please merge this if it is good to go? I would like to rebase my registry patch on top of this.

Apache-HBase · 2020-01-03T05:49:26Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 23s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 23 new or modified test files.
		_ HBASE-18095/client-locate-meta-no-zookeeper Compile Tests _
+0 🆗	mvndep	0m 36s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 54s	HBASE-18095/client-locate-meta-no-zookeeper passed
+1 💚	compile	1m 25s	HBASE-18095/client-locate-meta-no-zookeeper passed
+1 💚	checkstyle	2m 1s	HBASE-18095/client-locate-meta-no-zookeeper passed
+1 💚	shadedjars	5m 1s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 1s	HBASE-18095/client-locate-meta-no-zookeeper passed
+0 🆗	spotbugs	4m 47s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	5m 54s	HBASE-18095/client-locate-meta-no-zookeeper passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 37s	the patch passed
+1 💚	compile	1m 25s	the patch passed
+1 💚	javac	1m 25s	the patch passed
+1 💚	checkstyle	0m 34s	hbase-client: The patch generated 0 new + 14 unchanged - 2 fixed = 14 total (was 16)
+1 💚	checkstyle	1m 29s	The patch passed checkstyle in hbase-server
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedjars	5m 2s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	18m 40s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚	javadoc	1m 2s	the patch passed
+1 💚	findbugs	6m 45s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 4s	hbase-client in the patch passed.
-1 ❌	unit	193m 58s	hbase-server in the patch failed.
+1 💚	asflicense	1m 6s	The patch does not generate ASF License warnings.
		269m 8s

Reason	Tests
Failed junit tests	hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient
	hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-957/5/artifact/out/Dockerfile
GITHUB PR	#957
JIRA Issue	HBASE-23604
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 5e0cae99f245 4.15.0-70-generic #79-Ubuntu SMP Tue Nov 12 10:36:11 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-957/out/precommit/personality/provided.sh
git revision	HBASE-18095/client-locate-meta-no-zookeeper / `dffa9be`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-957/5/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-957/5/testReport/
Max. process+thread count	4960 (vs. ulimit of 10000)
modules	C: hbase-client hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-957/5/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

ndimiduk · 2020-01-03T17:06:19Z

@virajjasani you have anything to add here?

virajjasani · 2020-01-03T17:07:56Z

@virajjasani you have anything to add here?

changes look good and went through the conversations, +1 from my side

ndimiduk · 2020-01-03T17:24:45Z

@bharathv TestZooKeeperTableArchiveClient fails consistently for me. Looks like it's built around a mock registry instance. Mind taking a look first?

Apache-HBase · 2020-01-03T22:14:10Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 34s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 1s	The patch appears to include 23 new or modified test files.
		_ HBASE-18095/client-locate-meta-no-zookeeper Compile Tests _
+0 🆗	mvndep	0m 34s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 16s	HBASE-18095/client-locate-meta-no-zookeeper passed
+1 💚	compile	1m 16s	HBASE-18095/client-locate-meta-no-zookeeper passed
+1 💚	checkstyle	1m 49s	HBASE-18095/client-locate-meta-no-zookeeper passed
+1 💚	shadedjars	4m 40s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 1s	HBASE-18095/client-locate-meta-no-zookeeper passed
+0 🆗	spotbugs	4m 24s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	5m 31s	HBASE-18095/client-locate-meta-no-zookeeper passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 0s	the patch passed
+1 💚	compile	1m 24s	the patch passed
+1 💚	javac	1m 24s	the patch passed
+1 💚	checkstyle	0m 31s	hbase-client: The patch generated 0 new + 14 unchanged - 2 fixed = 14 total (was 16)
+1 💚	checkstyle	1m 17s	The patch passed checkstyle in hbase-server
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedjars	4m 32s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	16m 4s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚	javadoc	1m 0s	the patch passed
+1 💚	findbugs	5m 56s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 59s	hbase-client in the patch passed.
+1 💚	unit	157m 21s	hbase-server in the patch passed.
+1 💚	asflicense	1m 6s	The patch does not generate ASF License warnings.
		223m 38s

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-957/6/artifact/out/Dockerfile
GITHUB PR	#957
JIRA Issue	HBASE-23604
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 49619b10215a 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-957/out/precommit/personality/provided.sh
git revision	HBASE-18095/client-locate-meta-no-zookeeper / `dffa9be`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-957/6/testReport/
Max. process+thread count	4779 (vs. ulimit of 10000)
modules	C: hbase-client hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-957/6/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

* HBASE-23604: Cleanup AsyncRegistry interface - Cleans up the method names to make more sense and adds a little more javadocs for context. In future patches we can revisit the name of the actual class to make it more self explanatory. - Does AsyncRegistry -> ConnectionRegistry rename. "async" ness of the registry is kind of implicit based on the interface contents and need not be reflected in the name. Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: stack <stack@apache.org> Signed-off-by: Viraj Jasani <vjasani@apache.org>

* HBASE-23604: Cleanup AsyncRegistry interface - Cleans up the method names to make more sense and adds a little more javadocs for context. In future patches we can revisit the name of the actual class to make it more self explanatory. - Does AsyncRegistry -> ConnectionRegistry rename. "async" ness of the registry is kind of implicit based on the interface contents and need not be reflected in the name. Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: stack <stack@apache.org> Signed-off-by: Viraj Jasani <vjasani@apache.org> (cherry picked from commit 12bb41e)

* HBASE-23604: Cleanup AsyncRegistry interface - Cleans up the method names to make more sense and adds a little more javadocs for context. In future patches we can revisit the name of the actual class to make it more self explanatory. - Does AsyncRegistry -> ConnectionRegistry rename. "async" ness of the registry is kind of implicit based on the interface contents and need not be reflected in the name. Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: stack <stack@apache.org> Signed-off-by: Viraj Jasani <vjasani@apache.org>

* HBASE-23604: Cleanup AsyncRegistry interface - Cleans up the method names to make more sense and adds a little more javadocs for context. In future patches we can revisit the name of the actual class to make it more self explanatory. - Does AsyncRegistry -> ConnectionRegistry rename. "async" ness of the registry is kind of implicit based on the interface contents and need not be reflected in the name. Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: stack <stack@apache.org> Signed-off-by: Viraj Jasani <vjasani@apache.org> (cherry picked from commit 12bb41e)

* HBASE-23604: Cleanup AsyncRegistry interface - Cleans up the method names to make more sense and adds a little more javadocs for context. In future patches we can revisit the name of the actual class to make it more self explanatory. - Does AsyncRegistry -> ConnectionRegistry rename. "async" ness of the registry is kind of implicit based on the interface contents and need not be reflected in the name. Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: stack <stack@apache.org> Signed-off-by: Viraj Jasani <vjasani@apache.org>

* HBASE-23604: Cleanup AsyncRegistry interface - Cleans up the method names to make more sense and adds a little more javadocs for context. In future patches we can revisit the name of the actual class to make it more self explanatory. - Does AsyncRegistry -> ConnectionRegistry rename. "async" ness of the registry is kind of implicit based on the interface contents and need not be reflected in the name. Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: stack <stack@apache.org> Signed-off-by: Viraj Jasani <vjasani@apache.org> (cherry picked from commit 12bb41e)

* HBASE-23604: Cleanup AsyncRegistry interface - Cleans up the method names to make more sense and adds a little more javadocs for context. In future patches we can revisit the name of the actual class to make it more self explanatory. - Does AsyncRegistry -> ConnectionRegistry rename. "async" ness of the registry is kind of implicit based on the interface contents and need not be reflected in the name. Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: stack <stack@apache.org> Signed-off-by: Viraj Jasani <vjasani@apache.org>

saintstack reviewed Dec 21, 2019

View reviewed changes

bharathv force-pushed the HBASE-23604 branch 2 times, most recently from f94d2bc to 1d871ae Compare December 21, 2019 18:17

bharathv mentioned this pull request Dec 25, 2019

HBASE-23305: Master based registry implementation #954

Merged

saintstack approved these changes Dec 27, 2019

View reviewed changes

asfgit force-pushed the HBASE-18095/client-locate-meta-no-zookeeper branch from e41b46c to 1c41b36 Compare December 28, 2019 19:24

bharathv force-pushed the HBASE-23604 branch from 5d68e30 to 1928d33 Compare December 29, 2019 03:03

bharathv commented Dec 29, 2019

View reviewed changes

ndimiduk reviewed Jan 2, 2020

View reviewed changes

hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionRegistry.java Show resolved Hide resolved

hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionRegistryFactory.java Show resolved Hide resolved

asfgit force-pushed the HBASE-18095/client-locate-meta-no-zookeeper branch from 1c41b36 to dffa9be Compare January 3, 2020 00:21

bharathv force-pushed the HBASE-23604 branch from 1928d33 to e610314 Compare January 3, 2020 01:16

virajjasani approved these changes Jan 3, 2020

View reviewed changes

Fix TestZooKeeperTableArchiveClient

80b07af

ndimiduk merged commit d016cd9 into apache:HBASE-18095/client-locate-meta-no-zookeeper Jan 3, 2020

HBASE-23604: Clarify AsyncRegistry usage in the code. #957

HBASE-23604: Clarify AsyncRegistry usage in the code. #957

Uh oh!

Conversation

bharathv commented Dec 20, 2019

Uh oh!

Apache-HBase commented Dec 21, 2019

Uh oh!

saintstack left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

saintstack Dec 21, 2019

Choose a reason for hiding this comment

Uh oh!

bharathv commented Dec 21, 2019

Uh oh!

Apache-HBase commented Dec 21, 2019

Uh oh!

saintstack left a comment

Choose a reason for hiding this comment

Uh oh!

saintstack commented Dec 27, 2019

Uh oh!

bharathv commented Dec 27, 2019

Uh oh!

bharathv commented Dec 27, 2019

Uh oh!

Apache-HBase commented Dec 28, 2019

Uh oh!

saintstack commented Dec 28, 2019

Uh oh!

saintstack commented Dec 28, 2019

Uh oh!

bharathv left a comment

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Dec 29, 2019

Uh oh!

bharathv commented Dec 31, 2019

Uh oh!

Uh oh!

Uh oh!

ndimiduk commented Jan 2, 2020

Uh oh!

bharathv commented Jan 3, 2020

Uh oh!

Apache-HBase commented Jan 3, 2020

Uh oh!

ndimiduk commented Jan 3, 2020

Uh oh!

virajjasani commented Jan 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ndimiduk commented Jan 3, 2020

Uh oh!

Apache-HBase commented Jan 3, 2020

Uh oh!

Uh oh!

virajjasani commented Jan 3, 2020 •

edited

Loading