HBASE-23381: Improve Logging in HBase Commons Package #913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
HorizonNet
reviewed
Dec 8, 2019
| if (LOG.isInfoEnabled()) { | ||
| LOG.info("Could not successfully schedule chore: " + chore.getName()); | ||
| } | ||
| LOG.info("Could not successfully schedule chore: " + chore.getName()); |
There was a problem hiding this comment.
Why did you remove the check?
There was a problem hiding this comment.
Please use parameterized logging for the name. Also probably better to just pass the chore so we get the name and the desired period.
There was a problem hiding this comment.
@HorizonNet The LOG.info method will check internally if the log level is set to Info before emitting a log message, no need to do it twice. Since the log message is INFO level, it's almost certainly going to be enabled when running in production so it's not worth being too clever with regards to performance so I wouldn't normally bother making it parameterized if it's not already. However, I will make that adjustment since I'll emit the chore object instead of its getName().
Also, this should be an ERROR level logging, to include the stack trace.
There was a problem hiding this comment.
that's a good catch. This exception handling used to also be used as a non-error condition way of disabling the chore. agree that now it should probably call more attention to itself.
busbey
requested changes
Dec 8, 2019
| if (LOG.isInfoEnabled()) { | ||
| LOG.info("Could not successfully schedule chore: " + chore.getName()); | ||
| } | ||
| LOG.info("Could not successfully schedule chore: " + chore.getName()); |
There was a problem hiding this comment.
Please use parameterized logging for the name. Also probably better to just pass the chore so we get the name and the desired period.
hbase-common/src/main/java/org/apache/hadoop/hbase/ChoreService.java
Outdated
Show resolved
Hide resolved
| printChoreServiceDetails("requestCorePoolIncrease"); | ||
|
|
||
| if (LOG.isTraceEnabled()) { | ||
| LOG.trace("requestCorePoolIncrease"); |
There was a problem hiding this comment.
Why not leave all of this in the method and have it do a proper trace guard?
There was a problem hiding this comment.
Personal taste. It seems overkill to have a method just for logging. Nicer when I can just see the logging and move on with my life, not having to jump into a method. If that logging method was used 10 times and/or this method was heavily overloaded, I'd probably keep it, but for 2x, and some simple methods, it doesn't feel worth it.
There was a problem hiding this comment.
... it also gets confusing because folks need to know who is responsible for the logging guards... internal or external to the method. I've seen it done both ways and I've seen where people then don't include guards when they should or they double-bag it.
hbase-common/src/main/java/org/apache/hadoop/hbase/HBaseConfiguration.java
Show resolved
Hide resolved
| @@ -48,8 +46,6 @@ | |||
| @InterfaceAudience.Private | |||
| public class KeyValueUtil { | |||
|
|
|||
| private static final Logger LOG = LoggerFactory.getLogger(KeyValueUtil.class); | |||
There was a problem hiding this comment.
I'll have to review where we call these utility methods since we're pulling out all this logging.
Please no one merge this util someone has done that check.
There was a problem hiding this comment.
Great. Thanks. This goes under the heading of 'log and throw'.
There was a problem hiding this comment.
that's well and good in principle but only works if we actually log something about the exception when it's eventually caught. also depending on the severity it might be needed if we're at risk of stacktrace optimization by the JVM and log rolling making it so we can't actually get details from here when it comes time to log the exception elsewhere.
hbase-common/src/main/java/org/apache/hadoop/hbase/util/CommonFSUtils.java
Outdated
Show resolved
Hide resolved
hbase-common/src/main/java/org/apache/hadoop/hbase/util/CommonFSUtils.java
Outdated
Show resolved
Hide resolved
hbase-common/src/main/java/org/apache/hadoop/hbase/util/CommonFSUtils.java
Outdated
Show resolved
Hide resolved
hbase-common/src/main/java/org/apache/hadoop/hbase/util/CommonFSUtils.java
Outdated
Show resolved
Hide resolved
|
💔 -1 overall
This message was automatically generated. |
|
@busbey Made the requested changes. Just need your verdict on KeyValueUtil.java log-and-throw |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
belugabehr
force-pushed
the
HBASE-23381
branch
from
4b4caae to
09d1449
Compare
|
Sorry. I got all mixed up in my local repo. I ended up rebasing to squash my three commits and doing a force push. Sorry for the inconvenience. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
@busbey Want to give a blessing here sir? |
|
@saintstack @busbey Just merged in latest changes and fixed conflicts. Thanks! |
|
💔 -1 overall
This message was automatically generated. |
|
Is this one still active? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.