Skip to content

HBASE-29723: Backport "HBASE-25282: Remove processingServers in DeadServer as we can get this information by Procedure of master" to branch-2.6 #7471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 21, 2025
Merged

HBASE-29723: Backport "HBASE-25282: Remove processingServers in DeadServer as we can get this information by Procedure of master" to branch-2.6 #7471

merged 2 commits into from
Nov 21, 2025
+20 −75

Conversation

@kgeisz
Copy link
Contributor

@kgeisz kgeisz commented Nov 19, 2025

Original Jira: https://issues.apache.org/jira/browse/HBASE-25282
Backport Jira task: https://issues.apache.org/jira/browse/HBASE-29723

This pull request is a cherry-pick from PR #2657.

To avoid build failures and having to cherry-pick several other commits, the TestSyncReplicationStandbyKillRS.java file found in the commit we are cherry-picking has been left out of this PR.

Also, an additional line was added to MasterRpcServices.java in order to prevent a build failure.

@yuqi1129 @kgeisz
HBASE-25282 Remove processingServers in DeadServer as we can get this… (
db1054d 
apache#2657)

Signed-off-by: Guanghao Zhang <zghao@apache.org>
Change-Id: I60e364ed06334715583ad2c5e14efe89af2212f4
@Apache-HBase

This comment has been minimized.

Sign in to view
@kgeisz
Run mvn spotless:apply
fc6a48a 
Change-Id: Ic39e5adb5f93474b137215a5c5352b6b9a967741
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase
Copy link

Apache-HBase commented Nov 20, 2025

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 51s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ branch-2.6 Compile Tests _
+1 💚 mvninstall 3m 53s branch-2.6 passed
+1 💚 compile 3m 34s branch-2.6 passed
+1 💚 checkstyle 0m 45s branch-2.6 passed
+1 💚 spotbugs 2m 8s branch-2.6 passed
-1 ❌ spotless 0m 56s branch has 29 errors when running spotless:check, run spotless:apply to fix.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 36s the patch passed
+1 💚 compile 3m 34s the patch passed
+1 💚 javac 3m 34s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 46s the patch passed
+1 💚 spotbugs 2m 22s the patch passed
+1 💚 hadoopcheck 19m 53s Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.1.
+1 💚 spotless 1m 2s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 14s The patch does not generate ASF License warnings.
45m 38s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7471/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #7471
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 609ca7a372a6 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.6 / fc6a48a
Default Java Eclipse Adoptium-11.0.23+9
spotless https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7471/3/artifact/yetus-general-check/output/branch-spotless.txt
Max. process+thread count 80 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7471/3/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Nov 20, 2025

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 50s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+1 💚 mvninstall 3m 14s branch-2.6 passed
+1 💚 compile 0m 46s branch-2.6 passed
+1 💚 javadoc 0m 28s branch-2.6 passed
+1 💚 shadedjars 5m 47s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 2m 41s the patch passed
+1 💚 compile 0m 47s the patch passed
+1 💚 javac 0m 47s the patch passed
+1 💚 javadoc 0m 27s the patch passed
+1 💚 shadedjars 5m 42s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 215m 59s hbase-server in the patch passed.
241m 12s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7471/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #7471
Optional Tests javac javadoc unit compile shadedjars
uname Linux b3e137d18ff3 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.6 / fc6a48a
Default Java Temurin-1.8.0_412-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7471/3/testReport/
Max. process+thread count 3196 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7471/3/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Nov 20, 2025

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 49s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+1 💚 mvninstall 3m 29s branch-2.6 passed
+1 💚 compile 0m 52s branch-2.6 passed
+1 💚 javadoc 0m 26s branch-2.6 passed
+1 💚 shadedjars 6m 39s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 20s the patch passed
+1 💚 compile 0m 53s the patch passed
+1 💚 javac 0m 53s the patch passed
-0 ⚠️ javadoc 0m 26s /results-javadoc-javadoc-hbase-server.txt hbase-server generated 2 new + 95 unchanged - 2 fixed = 97 total (was 97)
+1 💚 shadedjars 6m 44s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 214m 12s hbase-server in the patch passed.
241m 59s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7471/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #7471
Optional Tests javac javadoc unit compile shadedjars
uname Linux 06f8a560510a 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.6 / fc6a48a
Default Java Eclipse Adoptium-11.0.23+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7471/3/testReport/
Max. process+thread count 3269 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7471/3/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Nov 21, 2025

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 15s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+1 💚 mvninstall 5m 29s branch-2.6 passed
+1 💚 compile 1m 32s branch-2.6 passed
+1 💚 javadoc 0m 44s branch-2.6 passed
+1 💚 shadedjars 9m 43s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 4m 57s the patch passed
+1 💚 compile 1m 43s the patch passed
+1 💚 javac 1m 43s the patch passed
+1 💚 javadoc 0m 56s hbase-server generated 0 new + 60 unchanged - 3 fixed = 60 total (was 63)
+1 💚 shadedjars 9m 15s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌ unit 246m 35s /patch-unit-hbase-server.txt hbase-server in the patch failed.
287m 0s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7471/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #7471
Optional Tests javac javadoc unit compile shadedjars
uname Linux 4a749dea0426 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.6 / fc6a48a
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7471/3/testReport/
Max. process+thread count 3289 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7471/3/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

taklwu
taklwu approved these changes Nov 21, 2025
View reviewed changes
Copy link
Contributor

@taklwu taklwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the failure of org.apache.hadoop.hbase.master.assignment.TestMergeTableRegionsProcedure was a timeout and is unrelated to this change.

@taklwu taklwu merged commit 8683cf6 into apache:branch-2.6 Nov 21, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taklwu taklwu taklwu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kgeisz @Apache-HBase @taklwu @yuqi1129