HBASE-29720: Backport "HBASE-25282: Remove processingServers in DeadServer as we can get this information by Procedure of master" to branch-2 #7463

kgeisz · 2025-11-13T02:04:55Z

Original Jira: https://issues.apache.org/jira/browse/HBASE-25282
Backport Jira task: https://issues.apache.org/jira/browse/HBASE-29720

This pull request is a cherry-pick from PR #2657.

To avoid build failures and having to cherry-pick several other commits, the TestSyncReplicationStandbyKillRS.java file found in the commit we are cherry-picking has been left out of this PR.

Also, an additional line was added to MasterRpcServices.java in order to prevent a build failure.

apache#2657) Signed-off-by: Guanghao Zhang <zghao@apache.org> Change-Id: I4398c3801c050b41505baf79167f1793e5544765

Change-Id: Ibb60d6e12ad51c8787aa308577acf512017c64f2

Apache-HBase · 2025-11-18T00:04:38Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 54s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 1s		Patch does not have any anti-patterns.
			_ branch-2 Compile Tests _
+1 💚	mvninstall	4m 43s		branch-2 passed
+1 💚	compile	3m 42s		branch-2 passed
+1 💚	checkstyle	0m 52s		branch-2 passed
+1 💚	spotbugs	2m 15s		branch-2 passed
+1 💚	spotless	1m 2s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 💚	mvninstall	4m 4s		the patch passed
+1 💚	compile	3m 2s		the patch passed
+1 💚	javac	3m 2s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 39s		the patch passed
+1 💚	spotbugs	1m 41s		the patch passed
+1 💚	hadoopcheck	17m 24s		Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.1.
+1 💚	spotless	0m 44s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 11s		The patch does not generate ASF License warnings.
		43m 36s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7463/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#7463
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux f1ed3d102162 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `f7a8682`
Default Java	Eclipse Adoptium-11.0.23+9
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7463/2/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-11-18T03:22:49Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 46s		Docker mode activated.
-0 ⚠️	yetus	0m 6s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2 Compile Tests _
+1 💚	mvninstall	3m 14s		branch-2 passed
+1 💚	compile	0m 46s		branch-2 passed
+1 💚	javadoc	0m 27s		branch-2 passed
+1 💚	shadedjars	5m 48s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	2m 34s		the patch passed
+1 💚	compile	0m 44s		the patch passed
+1 💚	javac	0m 44s		the patch passed
+1 💚	javadoc	0m 25s		the patch passed
+1 💚	shadedjars	5m 43s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	216m 19s		hbase-server in the patch passed.
		241m 53s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7463/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#7463
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux a05d222839e6 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `f7a8682`
Default Java	Temurin-1.8.0_412-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7463/2/testReport/
Max. process+thread count	3134 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7463/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-11-18T03:25:33Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 50s		Docker mode activated.
-0 ⚠️	yetus	0m 5s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2 Compile Tests _
+1 💚	mvninstall	4m 34s		branch-2 passed
+1 💚	compile	1m 3s		branch-2 passed
+1 💚	javadoc	0m 32s		branch-2 passed
+1 💚	shadedjars	6m 41s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 21s		the patch passed
+1 💚	compile	1m 2s		the patch passed
+1 💚	javac	1m 2s		the patch passed
+1 💚	javadoc	0m 30s		hbase-server generated 0 new + 60 unchanged - 3 fixed = 60 total (was 63)
+1 💚	shadedjars	6m 35s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	214m 38s		hbase-server in the patch passed.
		244m 36s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7463/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#7463
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux aad59e34a873 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `f7a8682`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7463/2/testReport/
Max. process+thread count	3416 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7463/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-11-18T03:40:51Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 51s		Docker mode activated.
-0 ⚠️	yetus	0m 5s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2 Compile Tests _
+1 💚	mvninstall	4m 10s		branch-2 passed
+1 💚	compile	0m 51s		branch-2 passed
+1 💚	javadoc	0m 27s		branch-2 passed
+1 💚	shadedjars	6m 41s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 7s		the patch passed
+1 💚	compile	0m 51s		the patch passed
+1 💚	javac	0m 51s		the patch passed
-0 ⚠️	javadoc	0m 25s	/results-javadoc-javadoc-hbase-server.txt	hbase-server generated 2 new + 95 unchanged - 2 fixed = 97 total (was 97)
+1 💚	shadedjars	6m 39s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	230m 53s		hbase-server in the patch passed.
		259m 51s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7463/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#7463
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 39406b8c9374 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `f7a8682`
Default Java	Eclipse Adoptium-11.0.23+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7463/2/testReport/
Max. process+thread count	3091 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7463/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

taklwu

the title should be

HBASE-xyz Backport HBASE-25282 "Remove processingServers in DeadServer as we can get this information by Procedure of master" to branch-2

where you will need to create a new JIRA for HBASE-xyz

kgeisz · 2025-11-19T00:20:51Z

the title should be

HBASE-xyz Backport HBASE-25282 "Remove processingServers in DeadServer as we can get this information by Procedure of master" to branch-2

where you will need to create a new JIRA for HBASE-xyz

@taklwu Thanks! I have created a new ticket and updated the PR title.

taklwu

LGTM, we will need another backport with https://issues.apache.org/jira/browse/HBASE-25334 to fix the right dead server in progress behavior

taklwu · 2025-11-19T01:34:24Z

hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestDeadServer.java

    ProcedureTestingUtility.submitAndWait(pExecutor, proc);

-    assertFalse(master.getServerManager().getDeadServers().areDeadServersInProgress());
+    assertTrue(master.getServerManager().areDeadServersInProgress());


we will also need https://issues.apache.org/jira/browse/HBASE-25334 /
a9b8c10 after this cherry-pick to have the right behavior.

This comment has been minimized.

Sign in to view

yuqi1129 and others added 2 commits November 17, 2025 13:29

HBASE-25282 Remove processingServers in DeadServer as we can get this… (

7c9b69c

apache#2657) Signed-off-by: Guanghao Zhang <zghao@apache.org> Change-Id: I4398c3801c050b41505baf79167f1793e5544765

Run mvn spotless:apply

f7a8682

Change-Id: Ibb60d6e12ad51c8787aa308577acf512017c64f2

kgeisz force-pushed the branch-2 branch from 7a80583 to f7a8682 Compare November 17, 2025 23:11

taklwu reviewed Nov 18, 2025

View reviewed changes

kgeisz changed the title ~~HBASE-25282 Remove processingServers in DeadServer as we can get this…~~ HBASE-29720: Backport "HBASE-25282: Remove processingServers in DeadServer as we can get this information by Procedure of master" to branch-2 Nov 19, 2025

taklwu approved these changes Nov 19, 2025

View reviewed changes

taklwu merged commit 1da3ccb into apache:branch-2 Nov 19, 2025
1 check passed

taklwu mentioned this pull request Nov 20, 2025

HBASE-29724: Backport "HBASE-25334: TestRSGroupsFallback.testFallback is flaky" into branch-2 and branch-2.6 #7472

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HBASE-29720: Backport "HBASE-25282: Remove processingServers in DeadServer as we can get this information by Procedure of master" to branch-2 #7463

HBASE-29720: Backport "HBASE-25282: Remove processingServers in DeadServer as we can get this information by Procedure of master" to branch-2 #7463

Uh oh!

kgeisz commented Nov 13, 2025 •

edited

Loading

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Apache-HBase commented Nov 18, 2025

Uh oh!

Apache-HBase commented Nov 18, 2025

Uh oh!

Apache-HBase commented Nov 18, 2025

Uh oh!

Apache-HBase commented Nov 18, 2025

Uh oh!

taklwu left a comment

Uh oh!

kgeisz commented Nov 19, 2025

Uh oh!

taklwu left a comment

Uh oh!

taklwu Nov 19, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

HBASE-29720: Backport "HBASE-25282: Remove processingServers in DeadServer as we can get this information by Procedure of master" to branch-2 #7463

HBASE-29720: Backport "HBASE-25282: Remove processingServers in DeadServer as we can get this information by Procedure of master" to branch-2 #7463

Uh oh!

Conversation

kgeisz commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Apache-HBase commented Nov 18, 2025

Uh oh!

Apache-HBase commented Nov 18, 2025

Uh oh!

Apache-HBase commented Nov 18, 2025

Uh oh!

Apache-HBase commented Nov 18, 2025

Uh oh!

taklwu left a comment

Choose a reason for hiding this comment

Uh oh!

kgeisz commented Nov 19, 2025

Uh oh!

taklwu left a comment

Choose a reason for hiding this comment

Uh oh!

taklwu Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kgeisz commented Nov 13, 2025 •

edited

Loading