Skip to content

HBASE-29708 Heartbeat messages can cause scans to be continued from the wrong row #7454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

HBASE-29708 Heartbeat messages can cause scans to be continued from the wrong row #7454

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .../src/main/java/org/apache/hadoop/hbase/client/AsyncScanSingleRegionRpcRetryingCaller.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,9 +460,9 @@ private void onError(Throwable error) {
retryTimer.newTimeout(t -> call(), delayNs, TimeUnit.NANOSECONDS);
}

private void updateNextStartRowWhenError(Result result) {
private void updateNextStartRowWhenError(Result result, boolean isHeartbeatMessage) {
Copy link
Contributor

@Apache9 Apache9 Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind adding some comments to describe the behavior? Especially on 3.x we do not have sync client implementation any more, we'd better add some comments so later developers could still know why we need this.

Copy link
Contributor Author

@stoty stoty Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment this seems to be not an HBase issue after all.

I am closing the PRs and tickets to avoid further confusion.

If the problem ends up being on the HBase side, I will repoen the ticket.

nextStartRowWhenError = result.getRow();
includeNextStartRowWhenError = result.mayHaveMoreCellsInRow();
includeNextStartRowWhenError = result.mayHaveMoreCellsInRow() || isHeartbeatMessage;
}

private void completeWhenNoMoreResultsInRegion() {
Expand Down Expand Up @@ -531,7 +531,7 @@ private void onComplete(HBaseRpcController controller, ScanResponse resp) {
if (results.length > 0) {
scanController = new ScanControllerImpl(
resp.hasCursor() ? Optional.of(ProtobufUtil.toCursor(resp.getCursor())) : Optional.empty());
updateNextStartRowWhenError(results[results.length - 1]);
updateNextStartRowWhenError(results[results.length - 1], isHeartbeatMessage);
consumer.onNext(results, scanController);
} else {
Optional<Cursor> cursor = Optional.empty();
Expand Down