HBASE-29707 Fix region cache % metrics miss calculation #7451
+205
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I436c20b079c34e7df9b90685936848ebb6d7236b
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Change-Id: I9d76998db2d23a0151580cba7e7a95bb7eb2ff18
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
kgeisz
approved these changes
Nov 12, 2025
Contributor
kgeisz
left a comment
kgeisz
left a comment
There was a problem hiding this comment.
LGTM. I just have on question and a nit comment
|
|
||
| public static boolean isHFileArchived(Path path) { | ||
| Path currentDir = path; | ||
| for (int i = 0; i < 6; i++) { |
Contributor
There was a problem hiding this comment.
Why does this always iterate 6 times? My assumption is it's because that's the max depth of an archived file. Can that ever be more than 6?
Contributor
Author
There was a problem hiding this comment.
I don't think so.
| Thread.sleep(1000); | ||
| } | ||
| // HFileLink use the path of the target file to create a reader, but the target file is in the | ||
| // archive, so it wasn't cached previously and should ba cached when we open the link. |
Contributor
There was a problem hiding this comment.
nit
Suggested change
| // archive, so it wasn't cached previously and should ba cached when we open the link. | |
| // archive, so it wasn't cached previously and should be cached when we open the link. |
petersomogyi
approved these changes
Nov 14, 2025
Change-Id: Ieb650a05c5242a0dc977a98fe59f362b3c9f3f8b
wchevreuil
added a commit
that referenced
this pull request
Nov 14, 2025
Signed-off-by: Peter Somogyi <psomogyi@apache.org> Reviewed-by: Kevin Geiszler <kevin.j.geiszler@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.