Skip to content

HBASE-23185 Fix high cpu usage because getTable()#put() gets config value every time #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 21, 2019
Merged

HBASE-23185 Fix high cpu usage because getTable()#put() gets config value every time #731

merged 2 commits into from
Oct 21, 2019
+123 −61

Conversation

bitterfox
Copy link
Contributor

@bitterfox bitterfox commented Oct 18, 2019 •
edited
Loading

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
💙 reexec 0m 39s Docker mode activated.
_ Prechecks _
💚 dupname 0m 0s No case conflicting files found.
💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
💚 @author 0m 0s The patch does not contain any @author tags.
💛 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-1 Compile Tests _
💚 mvninstall 10m 12s branch-1 passed
💚 compile 0m 20s branch-1 passed with JDK v1.8.0_232
💚 compile 0m 23s branch-1 passed with JDK v1.7.0_242
💚 checkstyle 0m 43s branch-1 passed
💚 shadedjars 2m 50s branch has no errors when building our shaded downstream artifacts.
💚 javadoc 0m 28s branch-1 passed with JDK v1.8.0_232
💚 javadoc 0m 25s branch-1 passed with JDK v1.7.0_242
💙 spotbugs 1m 31s Used deprecated FindBugs config; considering switching to SpotBugs.
💚 findbugs 1m 27s branch-1 passed
_ Patch Compile Tests _
💚 mvninstall 1m 57s the patch passed
💚 compile 0m 19s the patch passed with JDK v1.8.0_232
💚 javac 0m 19s the patch passed
💚 compile 0m 23s the patch passed with JDK v1.7.0_242
💚 javac 0m 23s the patch passed
💔 checkstyle 0m 38s hbase-client: The patch generated 7 new + 142 unchanged - 1 fixed = 149 total (was 143)
💚 whitespace 0m 0s The patch has no whitespace issues.
💚 shadedjars 2m 48s patch has no errors when building our shaded downstream artifacts.
💚 hadoopcheck 5m 3s Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
💚 javadoc 0m 20s the patch passed with JDK v1.8.0_232
💚 javadoc 0m 25s the patch passed with JDK v1.7.0_242
💚 findbugs 1m 31s the patch passed
_ Other Tests _
💚 unit 2m 38s hbase-client in the patch passed.
💚 asflicense 0m 18s The patch does not generate ASF License warnings.
37m 28s
Subsystem Report/Notes
Docker Client=19.03.3 Server=19.03.3 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-731/1/artifact/out/Dockerfile
GITHUB PR #731
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux ba66d440b7da 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-731/out/precommit/personality/provided.sh
git revision branch-1 / 425d84d
Default Java 1.7.0_242
Multi-JDK versions /usr/lib/jvm/zulu-8-amd64:1.8.0_232 /usr/lib/jvm/zulu-7-amd64:1.7.0_242
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-731/1/artifact/out/diff-checkstyle-hbase-client.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-731/1/testReport/
Max. process+thread count 148 (vs. ulimit of 10000)
modules C: hbase-client U: hbase-client
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-731/1/console
versions git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
💙 reexec 0m 40s Docker mode activated.
_ Prechecks _
💚 dupname 0m 0s No case conflicting files found.
💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
💚 @author 0m 0s The patch does not contain any @author tags.
💛 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-1 Compile Tests _
💚 mvninstall 8m 37s branch-1 passed
💚 compile 0m 19s branch-1 passed with JDK v1.8.0_232
💚 compile 0m 23s branch-1 passed with JDK v1.7.0_242
💚 checkstyle 0m 41s branch-1 passed
💚 shadedjars 2m 54s branch has no errors when building our shaded downstream artifacts.
💚 javadoc 0m 26s branch-1 passed with JDK v1.8.0_232
💚 javadoc 0m 27s branch-1 passed with JDK v1.7.0_242
💙 spotbugs 1m 30s Used deprecated FindBugs config; considering switching to SpotBugs.
💚 findbugs 1m 28s branch-1 passed
_ Patch Compile Tests _
💚 mvninstall 1m 56s the patch passed
💚 compile 0m 21s the patch passed with JDK v1.8.0_232
💚 javac 0m 21s the patch passed
💚 compile 0m 24s the patch passed with JDK v1.7.0_242
💚 javac 0m 24s the patch passed
💚 checkstyle 0m 36s hbase-client: The patch generated 0 new + 142 unchanged - 1 fixed = 142 total (was 143)
💚 whitespace 0m 0s The patch has no whitespace issues.
💚 shadedjars 2m 45s patch has no errors when building our shaded downstream artifacts.
💚 hadoopcheck 5m 0s Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
💚 javadoc 0m 20s the patch passed with JDK v1.8.0_232
💚 javadoc 0m 27s the patch passed with JDK v1.7.0_242
💚 findbugs 1m 30s the patch passed
_ Other Tests _
💚 unit 2m 39s hbase-client in the patch passed.
💚 asflicense 0m 17s The patch does not generate ASF License warnings.
35m 37s
Subsystem Report/Notes
Docker Client=19.03.3 Server=19.03.3 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-731/2/artifact/out/Dockerfile
GITHUB PR #731
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 64ed37c21f2a 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-731/out/precommit/personality/provided.sh
git revision branch-1 / 924e0f7
Default Java 1.7.0_242
Multi-JDK versions /usr/lib/jvm/zulu-8-amd64:1.8.0_232 /usr/lib/jvm/zulu-7-amd64:1.7.0_242
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-731/2/testReport/
Max. process+thread count 148 (vs. ulimit of 10000)
modules C: hbase-client U: hbase-client
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-731/2/console
versions git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@saintstack saintstack merged commit ce65db3 into apache:branch-1 Oct 21, 2019
@bitterfox bitterfox mentioned this pull request Oct 22, 2019
Merged
bitterfox added a commit to bitterfox/hbase that referenced this pull request Oct 22, 2019
@bitterfox
HBASE-23185 Fix high cpu usage because getTable()#put() gets config v…
986a494 
…alue every time (apache#731)
bitterfox added a commit to bitterfox/hbase that referenced this pull request Oct 22, 2019
@bitterfox
HBASE-23185 Fix high cpu usage because getTable()#put() gets config v…
982d8b8 
…alue every time (apache#731)
bitterfox added a commit to bitterfox/hbase that referenced this pull request Oct 22, 2019
@bitterfox
HBASE-23185 Fix high cpu usage because getTable()#put() gets config v…
50f7f74 
…alue every time (apache#731)
@bitterfox bitterfox mentioned this pull request Oct 22, 2019
Merged
@JeongDaeKim JeongDaeKim mentioned this pull request Oct 24, 2019
Closed
asfgit pushed a commit that referenced this pull request Oct 26, 2019
@busbey
Revert "HBASE-23185 Fix high cpu usage because getTable()#put() gets …
db2ce23 
…config value every time (#731)"

Causes failure in TestMasterNoCluster and TestCatalogJanitor

This reverts commit ce65db3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saintstack saintstack saintstack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bitterfox @Apache-HBase @saintstack