-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-23065 [hbtop] Top-N heavy hitter user and client drill downs #722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
86 changes: 86 additions & 0 deletions
86
hbase-client/src/main/java/org/apache/hadoop/hbase/UserMetrics.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,86 @@ | ||
| /** | ||
| * Copyright The Apache Software Foundation | ||
| * | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.hadoop.hbase; | ||
|
|
||
| import java.util.Map; | ||
|
|
||
| import org.apache.hadoop.hbase.util.Bytes; | ||
| import org.apache.yetus.audience.InterfaceAudience; | ||
| import org.apache.yetus.audience.InterfaceStability; | ||
|
|
||
| /** | ||
| * Encapsulates per-user load metrics. | ||
| */ | ||
| @InterfaceAudience.Public | ||
| @InterfaceStability.Evolving | ||
| public interface UserMetrics { | ||
|
|
||
| interface ClientMetrics { | ||
|
|
||
| String getHostName(); | ||
|
|
||
| long getReadRequestsCount(); | ||
|
|
||
| long getWriteRequestsCount(); | ||
|
|
||
| long getFilteredReadRequestsCount(); | ||
| } | ||
|
|
||
| /** | ||
| * @return the user name | ||
| */ | ||
| byte[] getUserName(); | ||
|
|
||
| /** | ||
| * @return the number of read requests made by user | ||
| */ | ||
| long getReadRequestCount(); | ||
|
|
||
| /** | ||
| * @return the number of write requests made by user | ||
| */ | ||
| long getWriteRequestCount(); | ||
|
|
||
| /** | ||
| * @return the number of write requests and read requests and coprocessor | ||
| * service requests made by the user | ||
| */ | ||
| default long getRequestCount() { | ||
| return getReadRequestCount() + getWriteRequestCount(); | ||
| } | ||
|
|
||
| /** | ||
| * @return the user name as a string | ||
| */ | ||
| default String getNameAsString() { | ||
| return Bytes.toStringBinary(getUserName()); | ||
| } | ||
|
|
||
| /** | ||
| * @return metrics per client(hostname) | ||
| */ | ||
| Map<String, ClientMetrics> getClientMetrics(); | ||
|
|
||
| /** | ||
| * @return count of filtered read requests for a user | ||
| */ | ||
| long getFilteredReadRequests(); | ||
| } | ||
151 changes: 151 additions & 0 deletions
151
hbase-client/src/main/java/org/apache/hadoop/hbase/UserMetricsBuilder.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,151 @@ | ||
| /** | ||
| * Copyright The Apache Software Foundation | ||
| * | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.hadoop.hbase; | ||
|
|
||
| import java.util.HashMap; | ||
| import java.util.Map; | ||
|
|
||
| import org.apache.hadoop.hbase.util.Strings; | ||
| import org.apache.yetus.audience.InterfaceAudience; | ||
|
|
||
| import org.apache.hbase.thirdparty.com.google.common.base.Preconditions; | ||
|
|
||
| import org.apache.hadoop.hbase.shaded.protobuf.generated.ClusterStatusProtos; | ||
|
|
||
| @InterfaceAudience.Private | ||
| public final class UserMetricsBuilder { | ||
|
|
||
| public static UserMetrics toUserMetrics(ClusterStatusProtos.UserLoad userLoad) { | ||
| UserMetricsBuilder builder = UserMetricsBuilder.newBuilder(userLoad.getUserName().getBytes()); | ||
| userLoad.getClientMetricsList().stream().map( | ||
| clientMetrics -> new ClientMetricsImpl(clientMetrics.getHostName(), | ||
| clientMetrics.getReadRequestsCount(), clientMetrics.getWriteRequestsCount(), | ||
| clientMetrics.getFilteredRequestsCount())).forEach(builder::addClientMetris); | ||
| return builder.build(); | ||
| } | ||
|
|
||
| public static ClusterStatusProtos.UserLoad toUserMetrics(UserMetrics userMetrics) { | ||
| ClusterStatusProtos.UserLoad.Builder builder = | ||
| ClusterStatusProtos.UserLoad.newBuilder().setUserName(userMetrics.getNameAsString()); | ||
| userMetrics.getClientMetrics().values().stream().map( | ||
| clientMetrics -> ClusterStatusProtos.ClientMetrics.newBuilder() | ||
| .setHostName(clientMetrics.getHostName()) | ||
| .setWriteRequestsCount(clientMetrics.getWriteRequestsCount()) | ||
| .setReadRequestsCount(clientMetrics.getReadRequestsCount()) | ||
| .setFilteredRequestsCount(clientMetrics.getFilteredReadRequestsCount()).build()) | ||
| .forEach(builder::addClientMetrics); | ||
| return builder.build(); | ||
| } | ||
|
|
||
| public static UserMetricsBuilder newBuilder(byte[] name) { | ||
| return new UserMetricsBuilder(name); | ||
| } | ||
|
|
||
|
|
||
| private final byte[] name; | ||
| private Map<String, UserMetrics.ClientMetrics> clientMetricsMap = new HashMap<>(); | ||
| private UserMetricsBuilder(byte[] name) { | ||
| this.name = name; | ||
| } | ||
|
|
||
| public UserMetricsBuilder addClientMetris(UserMetrics.ClientMetrics clientMetrics) { | ||
| clientMetricsMap.put(clientMetrics.getHostName(), clientMetrics); | ||
| return this; | ||
| } | ||
|
|
||
| public UserMetrics build() { | ||
| return new UserMetricsImpl(name, clientMetricsMap); | ||
| } | ||
|
|
||
| public static class ClientMetricsImpl implements UserMetrics.ClientMetrics { | ||
| private final long filteredReadRequestsCount; | ||
| private final String hostName; | ||
| private final long readRequestCount; | ||
| private final long writeRequestCount; | ||
|
|
||
| public ClientMetricsImpl(String hostName, long readRequest, long writeRequest, | ||
| long filteredReadRequestsCount) { | ||
| this.hostName = hostName; | ||
| this.readRequestCount = readRequest; | ||
| this.writeRequestCount = writeRequest; | ||
| this.filteredReadRequestsCount = filteredReadRequestsCount; | ||
| } | ||
|
|
||
| @Override public String getHostName() { | ||
| return hostName; | ||
| } | ||
|
|
||
| @Override public long getReadRequestsCount() { | ||
| return readRequestCount; | ||
| } | ||
|
|
||
| @Override public long getWriteRequestsCount() { | ||
| return writeRequestCount; | ||
| } | ||
|
|
||
| @Override public long getFilteredReadRequestsCount() { | ||
| return filteredReadRequestsCount; | ||
| } | ||
| } | ||
|
|
||
| private static class UserMetricsImpl implements UserMetrics { | ||
| private final byte[] name; | ||
| private final Map<String, ClientMetrics> clientMetricsMap; | ||
|
|
||
| UserMetricsImpl(byte[] name, Map<String, ClientMetrics> clientMetricsMap) { | ||
| this.name = Preconditions.checkNotNull(name); | ||
| this.clientMetricsMap = clientMetricsMap; | ||
| } | ||
|
|
||
| @Override public byte[] getUserName() { | ||
| return name; | ||
| } | ||
|
|
||
| @Override public long getReadRequestCount() { | ||
| return clientMetricsMap.values().stream().map(c -> c.getReadRequestsCount()) | ||
| .reduce(0L, Long::sum); | ||
| } | ||
|
|
||
| @Override public long getWriteRequestCount() { | ||
| return clientMetricsMap.values().stream().map(c -> c.getWriteRequestsCount()) | ||
| .reduce(0L, Long::sum); | ||
| } | ||
|
|
||
| @Override public Map<String, ClientMetrics> getClientMetrics() { | ||
| return this.clientMetricsMap; | ||
| } | ||
|
|
||
| @Override public long getFilteredReadRequests() { | ||
| return clientMetricsMap.values().stream().map(c -> c.getFilteredReadRequestsCount()) | ||
| .reduce(0L, Long::sum); | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| StringBuilder sb = Strings | ||
| .appendKeyValue(new StringBuilder(), "readRequestCount", this.getReadRequestCount()); | ||
| Strings.appendKeyValue(sb, "writeRequestCount", this.getWriteRequestCount()); | ||
| Strings.appendKeyValue(sb, "filteredReadRequestCount", this.getFilteredReadRequests()); | ||
| return sb.toString(); | ||
| } | ||
| } | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.