HBASE-29405 Run spotless:apply with java 17 when creating release #7116
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the maven_spotless_apply function to run the Spotless plugin with Java 17 in the release creation script.
- Prefixes the Maven invocation with
JAVA_HOMEpointing to a Java 17 install to satisfy plugin requirements. - Adds a comment explaining the Java version requirement.
| @@ -887,7 +887,8 @@ function get_hadoop3_version() { | |||
| # For 2.x, the generated CHANGES.md and RELEASENOTES.md may have lines end with whitespace and | |||
| # case spotless:check failure, so we should run spotless:apply before committing | |||
| function maven_spotless_apply() { | |||
| "${MVN[@]}" spotless:apply | |||
| # our spotless plugin version requires at lease java 11 to run, so we use java 17 here | |||
| JAVA_HOME="/usr/lib/jvm/java-17-openjdk-amd64" "${MVN[@]}" spotless:apply | |||
There was a problem hiding this comment.
[nitpick] Hard-coding the JAVA_HOME path may not work on all environments. Consider detecting the Java 17 installation dynamically or making the path configurable.
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
We use this as the java 17 path all cross the scripts. Can do abstract later.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.