HBASE-29223 Migrate Master Status Jamon page back to JSP

[PDavid]

ℹ️ Sorry, this PR is quite large. Maybe it is better to check the changes commit-by-commit.

This is the first step of the Jamon to JSP migration is the Master Status page.

Moved the Jamon code back to JSP. Changed the Jamon syntax back to JSP.
To transfer data between JSP pages I used request attributes.
Tried to preserve the code as much as possible but did some changes:

Sub-templates were usually extracted to separate JSP file (and included with <jsp:include), in some case it was extracted as Java method.

Extracted some sections from master page to separate JSP pages:

• Software Attributes
• Warnings

Extracted the long JavaScript from the master page which executes on page load to separate JS file.

Extracted some frequently used static methods to a new util class: MasterStatusUtil. Also added unit tests for the static methods in MasterStatusUtil.

Changed the Master Status page back to /master.jsp again. Now made sure that /master-status redirects to /master.jsp.

What do you think about this?

I'll create a new Jira for the rest of the Jamon files.

[PDavid]

Maybe we could just have these constants in MasterStatusUtil and then we don't need a separate class for this. What do you think?

[stoty]

No preference from me.

[PDavid]

I tested this locally in standalone mode after building with maven (mvn clean install -DskipTests && bin/start-hbase.sh). I created some tables, adding data with the ltt tool (bin/hbase ltt -num_keys 10000 -write 100:100 -num_tables 10 -multiput)

I will still have to test these special cases as these have special UI parts:

• Dead region servers
• Replication - peers
• Backup master
• RS groups

I will also test with Pseudo-Distributed mode.

[Apache9]

Let me see if the copilot can give some feedbacks since this is a very big change...

[Copilot]

Copilot reviewed 39 out of 45 changed files in this pull request and generated 3 comments.

Files not reviewed (6)

• hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/AssignmentManagerStatusTmpl.jamon: Language not supported
• hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/BackupMasterStatusTmpl.jamon: Language not supported
• hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/RSGroupListTmpl.jamon: Language not supported
• hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/RegionVisualizerTmpl.jamon: Language not supported
• hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon: Language not supported
• hbase-server/src/main/resources/hbase-webapps/master/index.html: Language not supported

[Copilot]

This line assumes that server2GroupMap.get(serverName.getAddress()) is non-null. Add a null check before calling getName() to avoid a possible NullPointerException.

Suggested change

	rsGroupName = server2GroupMap.get(serverName.getAddress()).getName();
	}
	RSGroupInfo groupInfo = server2GroupMap.get(serverName.getAddress());
	if (groupInfo != null) {
	rsGroupName = groupInfo.getName();
	} else {
	rsGroupName = "default";
	}
	}

[PDavid]

To be honest I'm not sure if this is a good suggestion.
What do you all think?

[PDavid]

For now I only added these assertions on the HTML content of the Master Status page. But we can add more sophisticated asserts in the future.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 27s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	jshint	0m 0s		jshint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+1 💚	mvninstall	3m 52s		master passed
+1 💚	compile	3m 26s		master passed
+1 💚	checkstyle	0m 35s		master passed
+1 💚	spotbugs	1m 37s		master passed
+1 💚	spotless	0m 52s		branch has no errors when running spotless:check.
-0 ⚠️	patch	0m 59s		Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 7s		the patch passed
+1 💚	compile	3m 25s		the patch passed
+1 💚	javac	3m 25s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 37s		hbase-server: The patch generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2)
+1 💚	xmllint	0m 0s		No new issues.
+1 💚	spotbugs	1m 38s		the patch passed
+1 💚	hadoopcheck	12m 20s		Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚	spotless	0m 45s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 12s		The patch does not generate ASF License warnings.
		40m 39s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6875/11/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6875
Optional Tests	dupname asflicense javac codespell detsecrets spotless spotbugs checkstyle compile hadoopcheck hbaseanti xmllint jshint
uname	Linux 8912bec941ba 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / a83fbf0
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	83 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6875/11/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 29s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+1 💚	mvninstall	4m 0s		master passed
+1 💚	compile	0m 59s		master passed
+1 💚	javadoc	0m 30s		master passed
+1 💚	shadedjars	6m 17s		branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	patch	6m 26s		Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 17s		the patch passed
+1 💚	compile	0m 59s		the patch passed
+1 💚	javac	0m 59s		the patch passed
+1 💚	javadoc	0m 27s		the patch passed
+1 💚	shadedjars	6m 14s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	215m 6s		hbase-server in the patch passed.
		242m 46s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6875/11/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6875
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux a27b97ee3a00 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / a83fbf0
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6875/11/testReport/
Max. process+thread count	3800 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6875/11/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[PDavid]

@NihalJain Can you please maybe check this PR? I'd appreciate your help very much. 🙏