HBASE-29145 Table Stats shows store file size as zero always for hbase:meta table #6859
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Apache9
reviewed
Mar 26, 2025
| double rSize = load.getStoreFileSize().get(Size.Unit.BYTE); | ||
| if (rSize > 0) { | ||
| fileSize = StringUtils.byteDesc((long) rSize); | ||
| if (totalStoreFileSizeMB == 0) { |
Contributor
There was a problem hiding this comment.
What do we actually fix here? What is the root cause of this problem?
Contributor
Author
There was a problem hiding this comment.
totalStoreFileSizeMB variable is not updated when the table is meta which is causing this issue, for user tables issue not exists.
For meta table there could be multiple replicas, so adding a check that only the first replica size is considerd.
Contributor
There was a problem hiding this comment.
OK, this is under the metaLocation != null condition.
For adding only the first replica size, why not testing j == 0?
Contributor
Author
There was a problem hiding this comment.
existing implementation has a check for metaLocation != null, I thought it would be incorrect to depend on the logic of j == 0.
If the primary replica metaLocation can never be null, we can just test for j==0.. I have updated the PR with this change
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
chandrasekhar-188k
force-pushed
the
br_HBASE-29145_branch-2
branch
from
6db7994 to
a0cb08a
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Apache9
approved these changes
Apr 11, 2025
chandrasekhar-188k
added a commit
that referenced
this pull request
Nov 22, 2025
…e:meta table (#6859) Signed-off-by: Duo Zhang <zhangduo@apache.org>
chandrasekhar-188k
added a commit
that referenced
this pull request
Nov 22, 2025
…e:meta table (#6859) Signed-off-by: Duo Zhang <zhangduo@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.