Skip to content

HBASE-28983 Static resources are not loaded on REST web UI pages in dev mode #6743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

PDavid
Copy link
Contributor

@PDavid PDavid commented Mar 3, 2025

This way the hbase-webapps/static source directory (which holds JS, CSS, image files) is not duplicated anymore. It is only present under hbase-server. This directory is then copied by maven-resources-plugin to the target directory of the REST and Thrift projects.

For this deleted the static directory below the Thrift project.

Signed-off-by: Nihal Jain nihaljain@apache.org
Reviewed-by: Andrew Purtell apurtell@apache.org
(cherry picked from commit 4e40bd5)

…ev mode (apache#6491)

This way the `hbase-webapps/static` source directory (which holds JS, CSS, image files) is not duplicated anymore. It is only present under `hbase-server`. This directory is then coped by maven-resources-plugin to the target directory of the REST and Thrift projects.

For this deleted the static directory below the Thrift project.

Signed-off-by: Nihal Jain <nihaljain@apache.org>
Reviewed-by: Andrew Purtell <apurtell@apache.org>
(cherry picked from commit 4e40bd5)
@PDavid
Copy link
Contributor Author

PDavid commented Mar 3, 2025

Now that the Bootstrap upgrade is merged to the branch-2 branch, this can be backported.

This is a backport of #6491 for the branch-2 branch.
I cherry-picked the commit from master (it applied cleanly).

I tested this locally by starting HBase in standalone mode (mvn clean install -DskipTests -Dhadoop.profile=3.0 && bin/start-hbase.sh) then starting REST server (bin/hbase rest start -p 8080):

image

Thrift Server started with bin/hbase thrift start -p 8081:

image

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 48s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 jshint 0m 0s jshint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
+1 💚 mvninstall 3m 19s branch-2 passed
+1 💚 compile 1m 17s branch-2 passed
+1 💚 spotless 0m 49s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
+1 💚 mvninstall 3m 11s the patch passed
+1 💚 compile 1m 14s the patch passed
+1 💚 javac 1m 14s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 xmllint 0m 0s No new issues.
+1 💚 hadoopcheck 17m 4s Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.
+1 💚 spotless 0m 47s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 18s The patch does not generate ASF License warnings.
31m 2s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6743/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #6743
Optional Tests dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile jshint
uname Linux d00ab7fab389 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / b0c2fed
Default Java Eclipse Adoptium-11.0.23+9
Max. process+thread count 77 (vs. ulimit of 30000)
modules C: hbase-thrift hbase-rest U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6743/1/console
versions git=2.34.1 maven=3.9.8 xmllint=20913
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 47s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for branch
+1 💚 mvninstall 2m 25s branch-2 passed
+1 💚 compile 0m 39s branch-2 passed
+1 💚 javadoc 0m 37s branch-2 passed
+1 💚 shadedjars 5m 26s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 2m 27s the patch passed
+1 💚 compile 0m 40s the patch passed
+1 💚 javac 0m 40s the patch passed
+1 💚 javadoc 0m 36s the patch passed
+1 💚 shadedjars 5m 21s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 6m 43s hbase-thrift in the patch passed.
+1 💚 unit 4m 11s hbase-rest in the patch passed.
33m 49s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6743/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #6743
Optional Tests javac javadoc unit shadedjars compile
uname Linux fe537a0d0e2e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / b0c2fed
Default Java Temurin-1.8.0_412-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6743/1/testReport/
Max. process+thread count 1730 (vs. ulimit of 30000)
modules C: hbase-thrift hbase-rest U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6743/1/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 45s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for branch
+1 💚 mvninstall 3m 5s branch-2 passed
+1 💚 compile 0m 49s branch-2 passed
+1 💚 javadoc 0m 32s branch-2 passed
+1 💚 shadedjars 6m 29s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 3m 8s the patch passed
+1 💚 compile 0m 46s the patch passed
+1 💚 javac 0m 46s the patch passed
+1 💚 javadoc 0m 30s the patch passed
+1 💚 shadedjars 6m 29s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 6m 49s hbase-thrift in the patch passed.
+1 💚 unit 4m 16s hbase-rest in the patch passed.
37m 34s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6743/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #6743
Optional Tests javac javadoc unit shadedjars compile
uname Linux 7a215b3e9b28 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / b0c2fed
Default Java Eclipse Adoptium-11.0.23+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6743/1/testReport/
Max. process+thread count 1800 (vs. ulimit of 30000)
modules C: hbase-thrift hbase-rest U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6743/1/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 43s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 10s Maven dependency ordering for branch
+1 💚 mvninstall 3m 11s branch-2 passed
+1 💚 compile 0m 45s branch-2 passed
+1 💚 javadoc 0m 30s branch-2 passed
+1 💚 shadedjars 6m 9s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
+1 💚 mvninstall 3m 3s the patch passed
+1 💚 compile 0m 46s the patch passed
+1 💚 javac 0m 46s the patch passed
+1 💚 javadoc 0m 29s the patch passed
+1 💚 shadedjars 6m 5s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 6m 41s hbase-thrift in the patch passed.
+1 💚 unit 3m 36s hbase-rest in the patch passed.
35m 54s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6743/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #6743
Optional Tests javac javadoc unit shadedjars compile
uname Linux 87ca23f83669 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / b0c2fed
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6743/1/testReport/
Max. process+thread count 1754 (vs. ulimit of 30000)
modules C: hbase-thrift hbase-rest U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6743/1/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@PDavid PDavid marked this pull request as ready for review March 3, 2025 15:19
@NihalJain
Copy link
Contributor

NihalJain commented Mar 5, 2025

Going to merge this in next 1 hr.

@NihalJain NihalJain merged commit 219a1a4 into apache:branch-2 Mar 5, 2025
1 check passed
@PDavid PDavid deleted the HBASE-28983-rest-ui-resources-missing-branch-2 branch March 5, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants