HBASE-23078 BaseLoadBalancer should consider region replicas when ran… #663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saintstack
approved these changes
Sep 26, 2019
Contributor
saintstack
left a comment
saintstack
left a comment
There was a problem hiding this comment.
Nice cleanup.
How you think this changes the behavior of the balancer?
| TableName tableName = regionInfo.getTable(); | ||
| if (services != null && | ||
| services.getTableDescriptors().get(tableName).getRegionReplication() > 1) { | ||
| hasRegionReplica = true; |
|
💔 -1 overall
This message was automatically generated. |
infraio
force-pushed
the
HBASE-23078
branch
from
e8de3bd to
f7ee213
Compare
ramkrish86
reviewed
Sep 27, 2019
| for (RegionInfo regionInfo : regions) { | ||
| TableName tableName = regionInfo.getTable(); | ||
| if (services != null && | ||
| services.getTableDescriptors().get(tableName).getRegionReplication() > 1) { |
Contributor
There was a problem hiding this comment.
I think the descriptors are anyway cached right? If so good.
Contributor
Author
There was a problem hiding this comment.
Updated in new patch. Will only getTableDescriptors once now.
Contributor
|
Looks good to me. |
|
💔 -1 overall
This message was automatically generated. |
infraio
force-pushed
the
HBASE-23078
branch
from
f7ee213 to
ae95608
Compare
|
🎊 +1 overall
This message was automatically generated. |
infraio
force-pushed
the
HBASE-23078
branch
from
ae95608 to
74514a6
Compare
Contributor
Author
|
Add the region replica UT back. |
|
💔 -1 overall
This message was automatically generated. |
…domAssignment and roundRobinAssignment
infraio
force-pushed
the
HBASE-23078
branch
from
74514a6 to
9cd844b
Compare
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
The failed ut not related and passed. |
asfgit
pushed a commit
that referenced
this pull request
Sep 29, 2019
…domAssignment and roundRobinAssignment (#663) Signed-off-by: stack <stack@apache.org>
asfgit
pushed a commit
that referenced
this pull request
Sep 29, 2019
…domAssignment and roundRobinAssignment (#663) Signed-off-by: stack <stack@apache.org>
infraio
added a commit
to infraio/hbase
that referenced
this pull request
Aug 17, 2020
…domAssignment and roundRobinAssignment (apache#663) Signed-off-by: stack <stack@apache.org>
symat
pushed a commit
to symat/hbase
that referenced
this pull request
Feb 17, 2021
…domAssignment and roundRobinAssignment (apache#663) Signed-off-by: stack <stack@apache.org> (cherry picked from commit c50e3f3) Change-Id: I596ee594082021941f21ceb1b8150fc85ccb513b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…domAssignment and roundRobinAssignment