-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-28983 Static resources are not loaded on REST web UI pages in dev mode #6582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
NihalJain
merged 1 commit into
apache:branch-3
from
PDavid:HBASE-28983-rest-ui-resources-missing-branch-3
Feb 20, 2025
Merged
HBASE-28983 Static resources are not loaded on REST web UI pages in dev mode #6582
NihalJain
merged 1 commit into
apache:branch-3
from
PDavid:HBASE-28983-rest-ui-resources-missing-branch-3
Feb 20, 2025
+46
−155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the backport of #6491 to |
Tested this the same way: #6491 (comment) |
…ev mode This way the `hbase-webapps/static` source directory (which holds JS, CSS, image files) is not duplicated anymore. It is only present under `hbase-server`. This directory is then coped by maven-resources-plugin to the target directory of the REST and Thrift projects. For this deleted the static directory below the Thrift project. (cherry picked from commit b445217)
a4e9417
to
c8f4bac
Compare
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way the
hbase-webapps/static
source directory (which holds JS, CSS, image files) is not duplicated anymore. It is only present underhbase-server
. This directory is then coped by maven-resources-plugin to the target directory of the REST and Thrift projects.For this deleted the static directory below the Thrift project.
(cherry picked from commit b445217)