Skip to content

HBASE-29000 SLF4j logging backend incorrectly picked up from Hadoop w… #6495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2024
Merged

HBASE-29000 SLF4j logging backend incorrectly picked up from Hadoop w… #6495

merged 1 commit into from
Nov 28, 2024
+2 −1

Conversation

stoty
Copy link
Contributor

@stoty stoty commented Nov 27, 2024

…hen external Hadoop is specified

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 44s Docker mode activated.
-0 ⚠️ yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
_ Patch Compile Tests _
_ Other Tests _
1m 43s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6495/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #6495
Optional Tests
uname Linux 5e6990642165 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 1104a24
Max. process+thread count 41 (vs. ulimit of 30000)
modules C: . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6495/1/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 44s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 spotless 0m 43s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 shellcheck 0m 2s No new issues.
+1 💚 spotless 0m 40s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 10s The patch does not generate ASF License warnings.
3m 25s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6495/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #6495
Optional Tests dupname asflicense codespell detsecrets shellcheck shelldocs spotless
uname Linux 1d182fcdc446 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 1104a24
Max. process+thread count 47 (vs. ulimit of 30000)
modules C: . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6495/1/console
versions git=2.34.1 maven=3.9.8 shellcheck=0.8.0
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@stoty stoty merged commit 7658672 into apache:master Nov 28, 2024
1 check passed
stoty added a commit that referenced this pull request Nov 28, 2024
@stoty
HBASE-29000 SLF4j logging backend incorrectly picked up from Hadoop w…
094cf78 
…hen external Hadoop is specified (#6495)

Signed-off-by: Nihal Jain <nihaljain@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
stoty added a commit to stoty/hbase that referenced this pull request Nov 28, 2024
@stoty
HBASE-29000 SLF4j logging backend incorrectly picked up from Hadoop w…
1673546 
…hen external Hadoop is specified (apache#6495)

Signed-off-by: Nihal Jain <nihaljain@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 7658672)
@stoty stoty mentioned this pull request Nov 28, 2024
Merged
stoty added a commit that referenced this pull request Nov 28, 2024
@stoty
HBASE-29000 SLF4j logging backend incorrectly picked up from Hadoop w…
d875c32 
…hen external Hadoop is specified (#6495)

Signed-off-by: Nihal Jain <nihaljain@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 7658672)
stoty added a commit that referenced this pull request Nov 28, 2024
@stoty
HBASE-29000 SLF4j logging backend incorrectly picked up from Hadoop w…
f875416 
…hen external Hadoop is specified (#6495)

Signed-off-by: Nihal Jain <nihaljain@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 7658672)
stoty added a commit that referenced this pull request Nov 28, 2024
@stoty
HBASE-29000 SLF4j logging backend incorrectly picked up from Hadoop w…
c345593 
…hen external Hadoop is specified (#6495)

Signed-off-by: Nihal Jain <nihaljain@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 7658672)
ndimiduk
ndimiduk reviewed Dec 3, 2024
View reviewed changes
bin/hbase
for f in ${HBASE_HOME}/lib/client-facing-thirdparty/log4j*.jar; do
if [ -f "${f}" ]; then
CLASSPATH="${CLASSPATH}:${f}"
CLASSPATH="${f}:${CLASSPATH}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shudder

Nice one.

gvprathyusha6 pushed a commit to gvprathyusha6/hbase that referenced this pull request Dec 19, 2024
@stoty
HBASE-29000 SLF4j logging backend incorrectly picked up from Hadoop w…
9c96d79 
…hen external Hadoop is specified (apache#6495)

Signed-off-by: Nihal Jain <nihaljain@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndimiduk ndimiduk ndimiduk left review comments

@NihalJain NihalJain NihalJain approved these changes

@Apache9 Apache9 Apache9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stoty @Apache-HBase @ndimiduk @NihalJain @Apache9