Skip to content

HBASE-28942 Purge all netty 3 dependencies by default #6406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

Apache9
Copy link
Contributor

@Apache9 Apache9 commented Oct 28, 2024

No description provided.

@Apache9 Apache9 self-assigned this Oct 28, 2024
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 40s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+0 🆗 mvndep 0m 26s Maven dependency ordering for branch
+1 💚 mvninstall 4m 28s master passed
+1 💚 compile 8m 35s master passed
+1 💚 checkstyle 1m 12s master passed
+1 💚 spotbugs 7m 48s master passed
+1 💚 spotless 0m 44s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for patch
+1 💚 mvninstall 3m 0s the patch passed
+1 💚 compile 7m 52s the patch passed
+1 💚 javac 7m 52s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 1m 12s the patch passed
+1 💚 xmllint 0m 0s No new issues.
+1 💚 spotbugs 7m 50s the patch passed
+1 💚 hadoopcheck 12m 14s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚 spotless 0m 51s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 32s The patch does not generate ASF License warnings.
66m 3s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6406/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #6406
Optional Tests dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile spotbugs checkstyle hbaseanti
uname Linux 31a3a5d3a8c8 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / f399717
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 188 (vs. ulimit of 30000)
modules C: hbase-external-blockcache . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6406/1/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 15s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for branch
+1 💚 mvninstall 3m 5s master passed
+1 💚 compile 2m 11s master passed
+1 💚 javadoc 2m 17s master passed
+1 💚 shadedjars 5m 23s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
+1 💚 mvninstall 2m 51s the patch passed
+1 💚 compile 2m 10s the patch passed
+1 💚 javac 2m 10s the patch passed
+1 💚 javadoc 2m 17s the patch passed
+1 💚 shadedjars 5m 22s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 295m 55s root in the patch passed.
329m 12s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6406/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #6406
Optional Tests javac javadoc unit shadedjars compile
uname Linux 71c8374cce63 5.4.0-192-generic #212-Ubuntu SMP Fri Jul 5 09:47:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / f399717
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6406/1/testReport/
Max. process+thread count 9271 (vs. ulimit of 30000)
modules C: hbase-external-blockcache . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6406/1/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@jojochuang jojochuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have a rule to ban netty3 from transitive dependencies like in here: https://github.com/apache/hbase/blob/master/hbase-shaded/hbase-shaded-with-hadoop-check-invariants/pom.xml#L94

@Apache9
Copy link
Contributor Author

Apache9 commented Oct 29, 2024

We have lots of enforcer rule in the root pom but unfortunately we still need to support compiling with hadoop 3.x so we can not add this rule...

@Apache9 Apache9 requested a review from ndimiduk October 30, 2024 01:50
Copy link
Member

@ndimiduk ndimiduk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite see how these changes match the title. Nett3 was a transitive dependency of one of these removed jars?

@Apache9
Copy link
Contributor Author

Apache9 commented Oct 30, 2024

The jmemcahed daemon depends on netty, so here I used mockito to inject the memcached client, then we do not need to start the jmemcached daemon any more.

Jmemcached is not active for more than 10 years...

@Apache9 Apache9 merged commit a2d508a into apache:master Oct 30, 2024
1 check passed
Apache9 added a commit to Apache9/hbase that referenced this pull request Oct 30, 2024
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
(cherry picked from commit a2d508a)
Apache9 added a commit that referenced this pull request Oct 30, 2024
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
(cherry picked from commit a2d508a)
Apache9 added a commit that referenced this pull request Nov 1, 2024
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
(cherry picked from commit a2d508a)
Apache9 added a commit that referenced this pull request Nov 1, 2024
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
(cherry picked from commit a2d508a)
(cherry picked from commit 286bd69)
Apache9 added a commit that referenced this pull request Nov 1, 2024
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
(cherry picked from commit a2d508a)
(cherry picked from commit 286bd69)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants