Skip to content

HBASE-28865 Implement proper string builder for MoveRegionRequest in ProtobufUtil.getShortTextFormat #6318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 14, 2024

Conversation

PDavid
Copy link
Contributor

@PDavid PDavid commented Sep 30, 2024

No description provided.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@PDavid PDavid marked this pull request as ready for review September 30, 2024 10:08
@PDavid PDavid force-pushed the HBASE-28865-MoveRegionRequest-toString branch from 7b3a71e to ce6146e Compare October 1, 2024 09:27
@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@PDavid PDavid force-pushed the HBASE-28865-MoveRegionRequest-toString branch from ce6146e to 1b20c92 Compare October 8, 2024 16:28
@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

Copy link
Contributor

@stoty stoty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@Apache-HBase

This comment has been minimized.

Copy link
Contributor

@stoty stoty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the too long line checkstyle warning.

@PDavid
Copy link
Contributor Author

PDavid commented Oct 10, 2024

Please fix the too long line checkstyle warning.

Thanks. 👍 Strange it did not broke the build. To be honest it was quite hard to find this checkstyle warning. Will fix it. 🤔

@stoty
Copy link
Contributor

stoty commented Oct 10, 2024

Thanks.
There is a link from the Yetus report in the PR conversation to the checkstyle report.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 44s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 2m 57s master passed
+1 💚 compile 0m 24s master passed
+1 💚 javadoc 0m 19s master passed
+1 💚 shadedjars 5m 20s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 2m 59s the patch passed
+1 💚 compile 0m 23s the patch passed
+1 💚 javac 0m 23s the patch passed
+1 💚 javadoc 0m 19s the patch passed
+1 💚 shadedjars 5m 19s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 1m 38s hbase-client in the patch passed.
21m 23s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6318/6/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #6318
Optional Tests javac javadoc unit compile shadedjars
uname Linux cc9936ed8dce 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 4755420
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6318/6/testReport/
Max. process+thread count 289 (vs. ulimit of 30000)
modules C: hbase-client U: hbase-client
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6318/6/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@stoty
Copy link
Contributor

stoty commented Oct 10, 2024

Please prepare a backport of this patch for branch-2.
It is needed for committing this on the 2.x branches.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 35s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+1 💚 mvninstall 3m 3s master passed
+1 💚 compile 0m 46s master passed
+1 💚 checkstyle 0m 16s master passed
+1 💚 spotbugs 0m 41s master passed
+1 💚 spotless 0m 43s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚 mvninstall 2m 53s the patch passed
+1 💚 compile 0m 46s the patch passed
-0 ⚠️ javac 0m 46s /results-compile-javac-hbase-client.txt hbase-client generated 1 new + 102 unchanged - 1 fixed = 103 total (was 103)
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 15s hbase-client: The patch generated 0 new + 18 unchanged - 1 fixed = 18 total (was 19)
+1 💚 spotbugs 0m 48s the patch passed
+1 💚 hadoopcheck 12m 0s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚 spotless 0m 51s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 10s The patch does not generate ASF License warnings.
31m 28s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6318/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #6318
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux cfbfa67c3397 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 4755420
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 83 (vs. ulimit of 30000)
modules C: hbase-client U: hbase-client
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6318/6/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@stoty stoty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@PDavid
Copy link
Contributor Author

PDavid commented Oct 10, 2024

Please prepare a backport of this patch for branch-2. It is needed for committing this on the 2.x branches.

Thanks, the backport to branch-2 is prepared here:
#6362

@stoty stoty merged commit f2e52f3 into apache:master Oct 14, 2024
1 check passed
stoty pushed a commit that referenced this pull request Oct 14, 2024
…ProtobufUtil.getShortTextFormat (#6318)

Signed-off-by: Istvan Toth <stoty@apache.org>
(cherry picked from commit f2e52f3)
@PDavid PDavid deleted the HBASE-28865-MoveRegionRequest-toString branch October 15, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants