HBASE-28875 FSHlog closewrite closeErrorCount should increment for initial catch exception #6278

srinireddy2020 · 2024-09-22T03:44:26Z

During close writer for FSHlog, if any error occured then for initial exception itself need to increment the closeErrorCount counter.

…itial catch exception

Apache-HBase · 2024-09-22T04:26:54Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 56s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ branch-2 Compile Tests _
+1 💚	mvninstall	3m 4s		branch-2 passed
+1 💚	compile	2m 50s		branch-2 passed
+1 💚	checkstyle	0m 38s		branch-2 passed
+1 💚	spotbugs	1m 37s		branch-2 passed
+1 💚	spotless	0m 47s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 💚	mvninstall	2m 57s		the patch passed
+1 💚	compile	2m 50s		the patch passed
+1 💚	javac	2m 50s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 40s		the patch passed
+1 💚	spotbugs	1m 43s		the patch passed
+1 💚	hadoopcheck	15m 41s		Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.
+1 💚	spotless	0m 44s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 12s		The patch does not generate ASF License warnings.
		36m 20s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6278/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6278
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux cacc0abb1606 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `2c789e7`
Default Java	Eclipse Adoptium-11.0.23+9
Max. process+thread count	76 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6278/1/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-09-22T04:33:46Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	2m 46s		Docker mode activated.
-0 ⚠️	yetus	0m 4s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2 Compile Tests _
+1 💚	mvninstall	2m 35s		branch-2 passed
+1 💚	compile	0m 42s		branch-2 passed
+1 💚	javadoc	0m 25s		branch-2 passed
+1 💚	shadedjars	5m 21s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	2m 24s		the patch passed
+1 💚	compile	0m 42s		the patch passed
+1 💚	javac	0m 42s		the patch passed
+1 💚	javadoc	0m 25s		the patch passed
+1 💚	shadedjars	5m 20s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	20m 45s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
		43m 12s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6278/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#6278
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 2b04af7e842c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `2c789e7`
Default Java	Temurin-1.8.0_412-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6278/1/testReport/
Max. process+thread count	1789 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6278/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-09-22T07:48:32Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	2m 58s		Docker mode activated.
-0 ⚠️	yetus	0m 6s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2 Compile Tests _
+1 💚	mvninstall	3m 19s		branch-2 passed
+1 💚	compile	0m 57s		branch-2 passed
+1 💚	javadoc	0m 29s		branch-2 passed
+1 💚	shadedjars	6m 3s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 7s		the patch passed
+1 💚	compile	0m 57s		the patch passed
+1 💚	javac	0m 57s		the patch passed
+1 💚	javadoc	0m 27s		the patch passed
+1 💚	shadedjars	5m 57s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	209m 24s		hbase-server in the patch passed.
		237m 56s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6278/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6278
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux b839f3620585 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `2c789e7`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6278/1/testReport/
Max. process+thread count	4587 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6278/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-09-22T08:01:57Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 31s		Docker mode activated.
-0 ⚠️	yetus	0m 5s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2 Compile Tests _
+1 💚	mvninstall	3m 5s		branch-2 passed
+1 💚	compile	0m 54s		branch-2 passed
+1 💚	javadoc	0m 29s		branch-2 passed
+1 💚	shadedjars	5m 30s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 2s		the patch passed
+1 💚	compile	0m 54s		the patch passed
+1 💚	javac	0m 54s		the patch passed
+1 💚	javadoc	0m 29s		the patch passed
+1 💚	shadedjars	5m 31s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	225m 24s		hbase-server in the patch passed.
		251m 23s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6278/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#6278
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux a9db2bfe49d1 5.4.0-192-generic #212-Ubuntu SMP Fri Jul 5 09:47:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `2c789e7`
Default Java	Eclipse Adoptium-11.0.23+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6278/1/testReport/
Max. process+thread count	5027 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6278/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2024-09-22T13:43:32Z

IIRC there is a related PR about FSHLog error handling? The problem is the way on how we get the unflushedEntries...

srinireddy2020 · 2024-09-26T04:49:36Z

IIRC there is a related PR about FSHLog error handling? The problem is the way on how we get the unflushedEntries...

@Apache9 Thanks for looking into this issue
Are you talking about this PR
https://github.com/apache/hbase/pull/6033/files#diff-aaeb20ce1167716648486517a3e904b0de6c666ec1f6aa2951c197166dd2a4f4

HBASE-28875 FSHlog closewrite closeErrorCount should increment for in…

2c789e7

…itial catch exception

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HBASE-28875 FSHlog closewrite closeErrorCount should increment for initial catch exception #6278

HBASE-28875 FSHlog closewrite closeErrorCount should increment for initial catch exception #6278

srinireddy2020 commented Sep 22, 2024

Uh oh!

Apache-HBase commented Sep 22, 2024

Uh oh!

Apache-HBase commented Sep 22, 2024

Uh oh!

Apache-HBase commented Sep 22, 2024

Uh oh!

Apache-HBase commented Sep 22, 2024

Uh oh!

Apache9 commented Sep 22, 2024

Uh oh!

srinireddy2020 commented Sep 26, 2024

Uh oh!

Uh oh!

HBASE-28875 FSHlog closewrite closeErrorCount should increment for initial catch exception #6278

Are you sure you want to change the base?

HBASE-28875 FSHlog closewrite closeErrorCount should increment for initial catch exception #6278

Conversation

srinireddy2020 commented Sep 22, 2024

Uh oh!

Apache-HBase commented Sep 22, 2024

Uh oh!

Apache-HBase commented Sep 22, 2024

Uh oh!

Apache-HBase commented Sep 22, 2024

Uh oh!

Apache-HBase commented Sep 22, 2024

Uh oh!

Apache9 commented Sep 22, 2024

Uh oh!

srinireddy2020 commented Sep 26, 2024

Uh oh!

Uh oh!