Skip to content

HBASE-27118 Add security headers to Thrift/HTTP server (branch-2) #6153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 14, 2024
Merged

HBASE-27118 Add security headers to Thrift/HTTP server (branch-2) #6153

merged 2 commits into from
Aug 14, 2024

Conversation

anmolnar
Copy link
Contributor

Backport of 97de291

@anmolnar
HBASE-27118 Add security headers to Thrift/HTTP server (apache#5864)
c384c03 
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Pankaj <pankajkumar@apache.org>
Signed-off-by: Istvan Toth <stoty@apache.org>
@anmolnar anmolnar requested a review from stoty August 13, 2024 18:38
@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 42s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for branch
+1 💚 mvninstall 3m 13s branch-2 passed
+1 💚 compile 1m 30s branch-2 passed
+1 💚 checkstyle 0m 50s branch-2 passed
+1 💚 spotbugs 1m 52s branch-2 passed
+1 💚 spotless 0m 47s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
-1 ❌ mvninstall 3m 6s /patch-mvninstall-root.txt root in the patch failed.
-1 ❌ compile 0m 35s /patch-compile-hbase-thrift.txt hbase-thrift in the patch failed.
-0 ⚠️ javac 0m 35s /patch-compile-hbase-thrift.txt hbase-thrift in the patch failed.
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 46s the patch passed
+1 💚 xmllint 0m 0s No new issues.
-1 ❌ spotbugs 0m 17s /patch-spotbugs-hbase-thrift.txt hbase-thrift in the patch failed.
-1 ❌ hadoopcheck 1m 50s The patch causes 20 errors with Hadoop v2.10.2.
-1 ❌ hadoopcheck 4m 8s The patch causes 20 errors with Hadoop v3.3.6.
-1 ❌ hadoopcheck 6m 31s The patch causes 20 errors with Hadoop v3.4.0.
+1 💚 spotless 0m 44s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 24s The patch does not generate ASF License warnings.
25m 42s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6153/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #6153
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless xmllint
uname Linux 3cf06187af75 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / c384c03
Default Java Eclipse Adoptium-11.0.23+9
hadoopcheck https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6153/1/artifact/yetus-general-check/output/patch-javac-2.10.2.txt
hadoopcheck https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6153/1/artifact/yetus-general-check/output/patch-javac-3.3.6.txt
hadoopcheck https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6153/1/artifact/yetus-general-check/output/patch-javac-3.4.0.txt
Max. process+thread count 76 (vs. ulimit of 30000)
modules C: hbase-http hbase-thrift hbase-rest U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6153/1/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 46s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
+1 💚 mvninstall 2m 34s branch-2 passed
+1 💚 compile 0m 52s branch-2 passed
+1 💚 javadoc 0m 47s branch-2 passed
+1 💚 shadedjars 5m 20s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
-1 ❌ mvninstall 2m 31s /patch-mvninstall-root.txt root in the patch failed.
-1 ❌ compile 0m 20s /patch-compile-hbase-thrift.txt hbase-thrift in the patch failed.
-0 ⚠️ javac 0m 20s /patch-compile-hbase-thrift.txt hbase-thrift in the patch failed.
+1 💚 javadoc 0m 46s the patch passed
+1 💚 shadedjars 5m 19s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 0m 44s hbase-http in the patch passed.
-1 ❌ unit 0m 20s /patch-unit-hbase-thrift.txt hbase-thrift in the patch failed.
+1 💚 unit 3m 59s hbase-rest in the patch passed.
26m 45s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6153/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #6153
Optional Tests javac javadoc unit compile shadedjars
uname Linux 17549be4c496 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / c384c03
Default Java Temurin-1.8.0_412-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6153/1/testReport/
Max. process+thread count 1720 (vs. ulimit of 30000)
modules C: hbase-http hbase-thrift hbase-rest U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6153/1/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 38s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 10s Maven dependency ordering for branch
+1 💚 mvninstall 3m 5s branch-2 passed
+1 💚 compile 1m 7s branch-2 passed
+1 💚 javadoc 1m 4s branch-2 passed
+1 💚 shadedjars 5m 33s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for patch
-1 ❌ mvninstall 2m 59s /patch-mvninstall-root.txt root in the patch failed.
-1 ❌ compile 0m 27s /patch-compile-hbase-thrift.txt hbase-thrift in the patch failed.
-0 ⚠️ javac 0m 27s /patch-compile-hbase-thrift.txt hbase-thrift in the patch failed.
+1 💚 javadoc 1m 2s the patch passed
+1 💚 shadedjars 5m 31s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 0m 52s hbase-http in the patch passed.
-1 ❌ unit 0m 27s /patch-unit-hbase-thrift.txt hbase-thrift in the patch failed.
+1 💚 unit 3m 24s hbase-rest in the patch passed.
28m 49s
Subsystem Report/Notes
Docker ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6153/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #6153
Optional Tests javac javadoc unit compile shadedjars
uname Linux f5a59f76cd3e 5.4.0-192-generic #212-Ubuntu SMP Fri Jul 5 09:47:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / c384c03
Default Java Eclipse Adoptium-11.0.23+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6153/1/testReport/
Max. process+thread count 1762 (vs. ulimit of 30000)
modules C: hbase-http hbase-thrift hbase-rest U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6153/1/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 43s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 10s Maven dependency ordering for branch
+1 💚 mvninstall 3m 1s branch-2 passed
+1 💚 compile 1m 9s branch-2 passed
+1 💚 javadoc 1m 5s branch-2 passed
+1 💚 shadedjars 5m 29s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
-1 ❌ mvninstall 2m 58s /patch-mvninstall-root.txt root in the patch failed.
-1 ❌ compile 0m 27s /patch-compile-hbase-thrift.txt hbase-thrift in the patch failed.
-0 ⚠️ javac 0m 27s /patch-compile-hbase-thrift.txt hbase-thrift in the patch failed.
+1 💚 javadoc 1m 5s the patch passed
+1 💚 shadedjars 5m 32s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 0m 50s hbase-http in the patch passed.
-1 ❌ unit 0m 27s /patch-unit-hbase-thrift.txt hbase-thrift in the patch failed.
+1 💚 unit 3m 26s hbase-rest in the patch passed.
28m 52s
Subsystem Report/Notes
Docker ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6153/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #6153
Optional Tests javac javadoc unit compile shadedjars
uname Linux d676845155f0 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / c384c03
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6153/1/testReport/
Max. process+thread count 1761 (vs. ulimit of 30000)
modules C: hbase-http hbase-thrift hbase-rest U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6153/1/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 45s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for branch
+1 💚 mvninstall 2m 23s branch-2 passed
+1 💚 compile 0m 52s branch-2 passed
+1 💚 javadoc 0m 46s branch-2 passed
+1 💚 shadedjars 5m 21s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 2m 26s the patch passed
+1 💚 compile 0m 53s the patch passed
+1 💚 javac 0m 53s the patch passed
+1 💚 javadoc 0m 45s the patch passed
+1 💚 shadedjars 5m 19s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 0m 45s hbase-http in the patch passed.
+1 💚 unit 6m 39s hbase-thrift in the patch passed.
+1 💚 unit 3m 56s hbase-rest in the patch passed.
32m 37s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6153/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #6153
Optional Tests javac javadoc unit compile shadedjars
uname Linux 0e0754df08f2 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / bfb3815
Default Java Temurin-1.8.0_412-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6153/2/testReport/
Max. process+thread count 1822 (vs. ulimit of 30000)
modules C: hbase-http hbase-thrift hbase-rest U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6153/2/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 41s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 9s Maven dependency ordering for branch
+1 💚 mvninstall 3m 6s branch-2 passed
+1 💚 compile 1m 10s branch-2 passed
+1 💚 javadoc 1m 6s branch-2 passed
+1 💚 shadedjars 5m 28s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for patch
+1 💚 mvninstall 3m 6s the patch passed
+1 💚 compile 1m 8s the patch passed
+1 💚 javac 1m 8s the patch passed
+1 💚 javadoc 1m 5s the patch passed
+1 💚 shadedjars 5m 31s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 0m 51s hbase-http in the patch passed.
+1 💚 unit 6m 47s hbase-thrift in the patch passed.
+1 💚 unit 3m 26s hbase-rest in the patch passed.
35m 14s
Subsystem Report/Notes
Docker ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6153/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #6153
Optional Tests javac javadoc unit compile shadedjars
uname Linux b7c97d0b2cdf 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / bfb3815
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6153/2/testReport/
Max. process+thread count 1560 (vs. ulimit of 30000)
modules C: hbase-http hbase-thrift hbase-rest U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6153/2/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 42s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for branch
+1 💚 mvninstall 3m 9s branch-2 passed
+1 💚 compile 1m 27s branch-2 passed
+1 💚 checkstyle 0m 46s branch-2 passed
+1 💚 spotbugs 1m 50s branch-2 passed
+1 💚 spotless 0m 45s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 3m 5s the patch passed
+1 💚 compile 1m 30s the patch passed
+1 💚 javac 1m 30s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 47s the patch passed
+1 💚 xmllint 0m 0s No new issues.
+1 💚 spotbugs 2m 18s the patch passed
+1 💚 hadoopcheck 16m 42s Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.
+1 💚 spotless 0m 45s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 24s The patch does not generate ASF License warnings.
36m 54s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6153/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #6153
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless xmllint
uname Linux af9630b148ea 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / bfb3815
Default Java Eclipse Adoptium-11.0.23+9
Max. process+thread count 77 (vs. ulimit of 30000)
modules C: hbase-http hbase-thrift hbase-rest U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6153/2/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 36s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
+1 💚 mvninstall 2m 59s branch-2 passed
+1 💚 compile 1m 7s branch-2 passed
+1 💚 javadoc 1m 3s branch-2 passed
+1 💚 shadedjars 5m 32s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
+1 💚 mvninstall 3m 3s the patch passed
+1 💚 compile 1m 7s the patch passed
+1 💚 javac 1m 7s the patch passed
+1 💚 javadoc 1m 3s the patch passed
+1 💚 shadedjars 5m 33s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 0m 52s hbase-http in the patch passed.
+1 💚 unit 8m 47s hbase-thrift in the patch passed.
+1 💚 unit 3m 27s hbase-rest in the patch passed.
37m 0s
Subsystem Report/Notes
Docker ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6153/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #6153
Optional Tests javac javadoc unit compile shadedjars
uname Linux c50215673d4a 5.4.0-192-generic #212-Ubuntu SMP Fri Jul 5 09:47:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / bfb3815
Default Java Eclipse Adoptium-11.0.23+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6153/2/testReport/
Max. process+thread count 1853 (vs. ulimit of 30000)
modules C: hbase-http hbase-thrift hbase-rest U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6153/2/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@anmolnar
Copy link
Contributor Author

@Apache9 @stoty Please review this backport.

stoty
stoty approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@stoty stoty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

BTW branch-2 backport PRs don't need reviews, we only use them to run the CI checks.

@anmolnar anmolnar merged commit be762db into apache:branch-2 Aug 14, 2024
1 check passed
anmolnar added a commit that referenced this pull request Aug 14, 2024
@anmolnar
HBASE-27118 Add security headers to Thrift/HTTP server (branch-2) (#6153
d855593 
)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Pankaj <pankajkumar@apache.org>
Signed-off-by: Istvan Toth <stoty@apache.org>
@anmolnar anmolnar deleted the HBASE-27118_x2 branch August 14, 2024 19:55
anmolnar added a commit to anmolnar/hbase that referenced this pull request Aug 15, 2024
@anmolnar
HBASE-27118 Add security headers to Thrift/HTTP server (branch-2) (ap…
4aba4eb 
…ache#6153)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Pankaj <pankajkumar@apache.org>
Signed-off-by: Istvan Toth <stoty@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stoty stoty stoty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anmolnar @Apache-HBase @stoty