Skip to content

HBASE-28731 Remove the IA.Private annotation on WALEdit's add methods… #6085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2024
Merged

HBASE-28731 Remove the IA.Private annotation on WALEdit's add methods… #6085

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALEdit.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,6 @@
* that came in as a single transaction. All the edits for a given transaction are written out as a
* single record, in PB format, followed (optionally) by Cells written via the WALCellEncoder.
* <p>
* This class is LimitedPrivate for CPs to read-only. The {@link #add} methods are classified as
* private methods, not for use by CPs.
* </p>
* <p>
* A particular WALEdit 'type' is the 'meta' type used to mark key operational events in the WAL
* such as compaction, flush, or region open. These meta types do not traverse hbase memstores. They
* are edits made by the hbase system rather than edit data submitted by clients. They only show in
Expand All @@ -73,7 +69,6 @@
* file. See the hand-off in FSWALEntry Constructor.
* @see WALKey
*/
// TODO: Do not expose this class to Coprocessors. It has set methods. A CP might meddle.
@InterfaceAudience.LimitedPrivate({ HBaseInterfaceAudience.REPLICATION,
HBaseInterfaceAudience.COPROC })
public class WALEdit implements HeapSize {
Expand Down Expand Up @@ -240,13 +235,11 @@ public boolean isReplay() {
return this.replay;
}

@InterfaceAudience.Private
public WALEdit add(Cell cell, byte[] family) {
getOrCreateFamilies().add(family);
return addCell(cell);
}

@InterfaceAudience.Private
public WALEdit add(Cell cell) {
// We clone Family each time we add a Cell. Expensive but safe. For CPU savings, use
// add(Map) or add(Cell, family).
Expand All @@ -270,7 +263,6 @@ public ArrayList<Cell> getCells() {
* that nothing else depends on the contents being immutable.
* @param cells the list of cells that this WALEdit now contains.
*/
@InterfaceAudience.Private
// Used by replay.
public void setCells(ArrayList<Cell> cells) {
this.cells = cells;
Expand Down