-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-28717 Support FuzzyRowFilter in REST interface #6061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is not a clean backport, minor change was needed to handle V1/V1 processed mask values. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -456,6 +518,12 @@ public FilterModel(Filter filter) { | |||
this.filters = new ArrayList<>(); | |||
this.filters.add(new FilterModel(((WhileMatchFilter) filter).getFilter())); | |||
break; | |||
case FuzzyRowFilter: | |||
this.fuzzyKeys = new ArrayList<>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: it might be worth to extract the size of the fuzzyKeys and initialize the array list with that as you do in other cases.
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
05a3d09
to
aa79f61
Compare
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
Signed-off-by: Ankit Singhal <ankit@apache.org> (cherry picked from commit 8aae266)
Signed-off-by: Ankit Singhal <ankit@apache.org>
No description provided.