-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-22971 Deprecated RSGroupAdminEndpoint and make RSGroup feature … #595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Not fully done yet, plan to only keep the Endpoint service for compatibility. Just put it here to see whether we break something. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1686157 to
4ca760f
Compare
ac916f4 to
613452b
Compare
This comment has been minimized.
This comment has been minimized.
3dcc39b to
ce72633
Compare
613452b to
4319c9a
Compare
|
💔 -1 overall
This message was automatically generated. |
e80c702 to
9300631
Compare
4319c9a to
16b821b
Compare
|
💔 -1 overall
This message was automatically generated. |
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| private FavoredNodesPromoter getFavoredNodePromoter() { | ||
| return (FavoredNodesPromoter) ((RSGroupBasedLoadBalancer) master.getLoadBalancer()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to cast to RSGroupBasedLoadBalancer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The return value for the MasterServices interface is still LoadBalancer so...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For 3.0, I thought we can change this in the future?
|
The master ui show RSGroup info by the coprocessor "RSGroupEndpoint" config. Need to update too. |
It uses RSGroupTableAccessor to access the rsgroup table directly. I think the problem here is that we will use the coprocessor to test whether we should show rs group on master web page. This can be done in another issue, as I think maybe we still need a flag about whether to enable rs group. |
16b821b to
6785780
Compare
|
💔 -1 overall
This message was automatically generated. |
...c/main/java/org/apache/hadoop/hbase/master/procedure/AbstractStateMachineTableProcedure.java
Outdated
Show resolved
Hide resolved
Yes. May be another issue. Use RSGroupInfoManager to get the rsgroups directly. And only show the ui when there are more than one rsgroups. |
6785780 to
e75cbe0
Compare
|
💔 -1 overall
This message was automatically generated. |
e75cbe0 to
2c0ad1b
Compare
38fe1b0 to
b08f8de
Compare
|
💔 -1 overall
This message was automatically generated. |
b08f8de to
1ce143d
Compare
|
💔 -1 overall
This message was automatically generated. |
…always enabled (#595) Signed-off-by: Guanghao Zhang <zghao@apache.org>
…always enabled (#595) Signed-off-by: Guanghao Zhang <zghao@apache.org>
…always enabled (#595) Signed-off-by: Guanghao Zhang <zghao@apache.org>
…always enabled (#595) Signed-off-by: Guanghao Zhang <zghao@apache.org>
…always enabled (#595) Signed-off-by: Guanghao Zhang <zghao@apache.org>
…always enabled (#595) Signed-off-by: Guanghao Zhang <zghao@apache.org>
…always enabled (#595) Signed-off-by: Guanghao Zhang <zghao@apache.org>
…always enabled (#595) Signed-off-by: Guanghao Zhang <zghao@apache.org>
…always enabled (#595) Signed-off-by: Guanghao Zhang <zghao@apache.org>
…always enabled (#595) Signed-off-by: Guanghao Zhang <zghao@apache.org>
…always enabled (#595) Signed-off-by: Guanghao Zhang <zghao@apache.org>
…always enabled (#595) Signed-off-by: Guanghao Zhang <zghao@apache.org>
…always enabled (#595) Signed-off-by: Guanghao Zhang <zghao@apache.org>
…always enabled (#595) Signed-off-by: Guanghao Zhang <zghao@apache.org>
…always enabled (#595) Signed-off-by: Guanghao Zhang <zghao@apache.org>
…always enabled (#595) Signed-off-by: Guanghao Zhang <zghao@apache.org>
…always enabled (#595) Signed-off-by: Guanghao Zhang <zghao@apache.org>
…always enabled (#595) Signed-off-by: Guanghao Zhang <zghao@apache.org>
…always enabled (#595) Signed-off-by: Guanghao Zhang <zghao@apache.org>
…always enabled (#595) Signed-off-by: Guanghao Zhang <zghao@apache.org>
…always enabled (#595) Signed-off-by: Guanghao Zhang <zghao@apache.org>
…always enabled (apache#595) Signed-off-by: Guanghao Zhang <zghao@apache.org>
…always enabled (apache#595) Signed-off-by: Guanghao Zhang <zghao@apache.org>
…always enabled